Bug 228916 - Merge GELI UEFI (installer changes for this too)
Summary: Merge GELI UEFI (installer changes for this too)
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: Warner Losh
URL:
Keywords:
Depends on: 228945
Blocks: 228911
  Show dependency tree / graph
 
Reported: 2018-06-12 08:19 UTC by Rodney W. Grimes
Modified: 2021-06-18 11:52 UTC (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney W. Grimes freebsd_committer freebsd_triage 2018-06-12 08:19:37 UTC 
Merge GELI UEFI (installer changes for this too)
Comment 1 Rodney W. Grimes freebsd_committer freebsd_triage 2018-06-12 08:29:41 UTC 
Can someone find a proper email address for Eric McCorkle to put in the CC list.
Comment 2 Allan Jude freebsd_committer freebsd_triage 2018-06-12 14:03:17 UTC 
Eric's Address is: eric@metricspace.net but Bugzilla doesn't have an account for it
Comment 3 Warner Losh freebsd_committer freebsd_triage 2018-06-12 14:30:52 UTC 
Ian Lepore posted a more generic, GELI booting patch that works everywhere. We will need to reconcile that patch with Eric's work. The sticking point on Eric's work is that it is a UEFI driver and works only there and may undo the layering stuff that was recently added for MBR + disklabel setups. We'll need to see which elements of it are truly required after Ian's work.

We also need improvements to the test-harness.
Comment 4 Ian Lepore freebsd_committer freebsd_triage 2018-06-12 15:33:55 UTC 
My architecture/device-neutral solution to this problem, not yet tested in the EFI environment but expected to work there, can be found at https://reviews.freebsd.org/D15743
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2018-06-12 21:56:19 UTC 
(In reply to Rodney W. Grimes from comment #1)

I had already privately asked Eric if/how he wanted to be notified.
Comment 6 Ed Maste freebsd_committer freebsd_triage 2018-07-24 15:24:38 UTC 
https://reviews.freebsd.org/rS336252
Extend loader(8) geli support to all architectures and all disk-like devices.
Comment 7 Allan Jude freebsd_committer freebsd_triage 2018-08-23 03:50:48 UTC 
Installer improvements to support UEFI/GELI in ZFS mode:
https://reviews.freebsd.org/D12315
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-08-23 22:50:51 UTC 
A commit references this bug:

Author: allanjude
Date: Thu Aug 23 22:50:12 UTC 2018
New revision: 338282
URL: https://svnweb.freebsd.org/changeset/base/338282

Log:
  bsdinstall/zfsboot: Enable new UEFI+GELI support

  After r336252 it is no longer necessary to have a separate bootpool when
  booting from an encrypted disk with UEFI.

  This change also switches the EFI System Partition contents from
  the 800 KB boot1.efifat to a new 200 MB filesystem created with newfs_msdos
  and uses loader.efi directly, instead of boot1.efi.

  PR:		228916
  Reviewed by:	dteske
  MFC after:	1 month
  Relnotes:	yes
  Sponsored by:	Klara Systems
  Differential Revision:	https://reviews.freebsd.org/D12315

Changes:
  head/usr.sbin/bsdinstall/scripts/zfsboot