Bug 229118 - net/grive2: Merge patches from upstream, unbreak build on powerpc64
Summary: net/grive2: Merge patches from upstream, unbreak build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Carlos J. Puga Medina
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-18 17:31 UTC by Carlos J. Puga Medina
Modified: 2018-07-27 21:19 UTC (History)
1 user (show)

See Also:

Attachments
patch-grive2 (4.05 KB, patch)
2018-06-18 17:31 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch-grive2 (4.23 KB, patch)
2018-07-13 17:16 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch-grive2 (3.77 KB, patch)
2018-07-25 18:52 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch-grive2 (3.76 KB, patch)
2018-07-25 19:22 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch-grive2 (5.95 KB, patch)
2018-07-25 19:58 UTC, Carlos J. Puga Medina 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-06-18 17:31:30 UTC 
Created attachment 194368 [details]
patch-grive2

- Unbreak build on powerpc64
- Register BUILD_CONFLICTS with binutils port
- Fix uninitialized use of c2 variable in State::FromLocal
- Link against specific Boost libraries, avoid using Boost_LIBRARIES
- Bump PORTREVISION
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-06-18 17:34:15 UTC 
(In reply to Carlos J. Puga Medina from comment #0)

s/BUILD_CONFLICTS/CONFLICTS_BUILD
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2018-07-10 20:58:21 UTC 
Even with this patch I still get:

    Run Build Command:"/usr/local/bin/ninja" "cmTC_4e24e"
    [1/2] Building CXX object CMakeFiles/cmTC_4e24e.dir/testCXXCompiler.cxx.o
    FAILED: CMakeFiles/cmTC_4e24e.dir/testCXXCompiler.cxx.o
    /usr/bin/c++    -O2 -pipe -isystem /usr/local/include -fno-strict-aliasing  -Wno-c++11-narrowing -isystem /usr/local/include -o CMakeFiles/cmTC_4e24e.dir/testCXXCompiler.cxx.o -c testCXXCompiler.cxx
    cc1plus: error: unrecognized command line option "-Wno-c++11-narrowing"
    ninja: build stopped: subcommand failed.
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-07-13 17:16:22 UTC 
Created attachment 195117 [details]
patch-grive2

I see that gcc 4.2 doesn't recognize -Wno-c++11-narrowing and treats it as an error.

The new patch should fix the build error on powerpc64.
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-07-25 18:52:49 UTC 
Created attachment 195454 [details]
patch-grive2

- Remove patches added upstream
- Add BACKTRACE option
Comment 5 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-07-25 19:22:34 UTC 
Created attachment 195455 [details]
patch-grive2

- Link against libexecinfo is only needed when BACKTRACE support is enabled.
Comment 6 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-07-25 19:58:46 UTC 
Created attachment 195457 [details]
patch-grive2

Really remove patch files added upstream.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-07-27 21:17:38 UTC 
A commit references this bug:

Author: cpm
Date: Fri Jul 27 21:17:19 UTC 2018
New revision: 475467
URL: https://svnweb.freebsd.org/changeset/ports/475467

Log:
  - Unbreak build on powerpc64
  - Add BACKTRACE option
  - Remove patches added upstream
  - Bump PORTREVISION

  PR:		229118

Changes:
  head/net/grive2/Makefile
  head/net/grive2/distinfo
  head/net/grive2/files/patch-CMakeLists.txt
  head/net/grive2/files/patch-grive_CMakeLists.txt
  head/net/grive2/files/patch-libgrive_CMakeLists.txt
  head/net/grive2/files/patch-libgrive_src_util_File.cc