Bug 229210 - net-p2p/qbittorrent: qt5-svg only required for default flavor
Summary: net-p2p/qbittorrent: qt5-svg only required for default flavor
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-21 15:53 UTC by Ralf van der Enden
Modified: 2018-06-21 16:24 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+

Attachments
move qt5-svg from global to nox flavor (845 bytes, patch)
2018-06-21 15:53 UTC, Ralf van der Enden 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2018-06-21 15:53:46 UTC 
Created attachment 194462 [details]
move qt5-svg from global to nox flavor

When building net-p2p/qbittorrent@nox, I noticed a lot of X11 and Qt5 libraries were being built, which are not required. This was caused by USE_QT5=svg being set as a generic dependency. Once I moved it to the 'nox' flavor if-block, things built as expected.

Bumped PORTREVISION as well.

Poudriere buildlog (nox-flavor only): https://pkg.cainites.net/data/latest-per-pkg/qbittorrent-nox/4.1.1_1/freebsd_11x64-system.log
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-06-21 16:23:27 UTC 
Committed.
Thanks for submitting the patch!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-06-21 16:24:01 UTC 
A commit references this bug:

Author: yuri
Date: Thu Jun 21 16:23:16 UTC 2018
New revision: 472982
URL: https://svnweb.freebsd.org/changeset/ports/472982

Log:
  net-p2p/qbittorrent: Limit USE_QT5=svg to @default flavor

  It is only needed for the UI.

  PR:		229210
  Submitted by:	Ralf van der Enden <tremere@cainites.net>

Changes:
  head/net-p2p/qbittorrent/Makefile