Source code is CSR_WRITE_4(sc, JZ_TC_TECR, TESR_TCST0 | TESR_TCST1 | TESR_TCST2 | TESR_TCST3 | TESR_TCST4 | TESR_TCST5 | TESR_TCST6 | TESR_TCST3); Maybe better code: CSR_WRITE_4(sc, JZ_TC_TECR, TESR_TCST0 | TESR_TCST1 | TESR_TCST2 | TESR_TCST3 | TESR_TCST4 | TESR_TCST5 | TESR_TCST6 | TESR_TCST7);
A commit references this bug: Author: gonzo Date: Fri Jan 25 20:02:56 UTC 2019 New revision: 343448 URL: https://svnweb.freebsd.org/changeset/base/343448 Log: [mips] Fix counter mask in jz4780 timer driver Fix dublicate value in what is apparent copypaste mistake. The last value in mask is supposed to be for counter 7, not counter 3. PR: 229790 Submitted by: David Binderman <dcb314@hotmail.com> MFC after: 1 week Changes: head/sys/mips/ingenic/jz4780_timer.c
Fix committed, thanks for reporting.
A commit references this bug: Author: gonzo Date: Sun Feb 3 08:53:04 UTC 2019 New revision: 343709 URL: https://svnweb.freebsd.org/changeset/base/343709 Log: MFC r343443, r343446, r343448, r343452 r343443: [mips] remove dublicate values in enable mask in nlm_usb_intr_en PR: 230572 Submitted by: David Binderman <dcb314@hotmail.com> r343446: [mips] remove check that is always false (unsinged < 0) cpuid and local cpu variable are unsigned so checking if value is less than zero always yields false. PR: 211088 Submitted by: David Binderman <dcb314@hotmail.com> r343448: [mips] Fix counter mask in jz4780 timer driver Fix dublicate value in what is apparent copypaste mistake. The last value in mask is supposed to be for counter 7, not counter 3. PR: 229790 Submitted by: David Binderman <dcb314@hotmail.com> r343452: [mips] Fix error condition check that always evaluates to false Use proper logical operand when checking the value of srcid PR: 200988 Submitted by: David Binderman <dcb314@hotmail.com> Changes: _U stable/12/ stable/12/sys/mips/ingenic/jz4780_timer.c stable/12/sys/mips/mips/tlb.c stable/12/sys/mips/nlm/cms.c stable/12/sys/mips/nlm/usb_init.c