Bug 230141 (file534) - [file] update file to 5.34
Summary: [file] update file to 5.34
Status: Closed FIXED
Alias: file534
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Eitan Adler
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-07-29 06:30 UTC by Eitan Adler
Modified: 2018-08-08 01:56 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments
update file to 5.34 (257.25 KB, patch)
2018-07-29 06:30 UTC, Eitan Adler
no flags Details | Diff
update file to 5.34 (257.08 KB, patch)
2018-07-29 19:16 UTC, Eitan Adler
no flags Details | Diff
update file to 5.34 (257.08 KB, patch)
2018-08-02 07:13 UTC, Eitan Adler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eitan Adler freebsd_committer freebsd_triage 2018-07-29 06:30:08 UTC
Created attachment 195583 [details]
update file to 5.34

I'd like to update file(1) to 5.34. Since the ports framework uses file(1) I am filing this bug as a exp-run placeholder.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2018-07-29 08:25:57 UTC
Before an exp-run,  did you try to build a few ports, lang/gcc6 for instance?
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2018-07-29 08:38:09 UTC
> Before an exp-run,  did you try to build a few ports, lang/gcc6 for instance?

I'm running with this change locally, but since I use poudriere to build ports, it was immune from the change.  I'll try now.
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2018-07-29 08:51:52 UTC
gcc6 shows this during stage-qa but I don't think it is file(1) related:

Error: /usr/local/lib/gcc6/libcilkrts.so.5.0.0 is linked to /usr/local/lib/gcc9/libstdc++.so.6 from lang/gcc9-devel but it is not declared as a dependency
Error: /usr/local/lib/gcc6/libgfortran.so.3.0.0 is linked to /usr/local/lib/gcc9/libquadmath.so.0 from lang/gcc9-devel but it is not declared as a dependency

Testing more random ports that I use sees nothing broken.  Is there something specific you're worried about or just want to know that I've done by due diligence?
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2018-07-29 08:59:11 UTC
What does "make -C $PORTSDIR/lang/gcc6 lib-depends" says?
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2018-07-29 09:08:30 UTC
It successfully builds gmp and then fails to install it, as its already installed. The  confused is likely since I've already installed many of the dependencies via packages. The primary reason I use poudriere now-a-days is to avoid having to debug issues like this. :)

Is this related to the file(1) upgrade? Reverting it doesn't seem to change anything.
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2018-07-29 09:18:07 UTC
With a "working" file,  it should just print:

% make -C /usr/ports/lang/gcc6 lib-depends
===>   gcc6-6.4.0_7 depends on shared library: libgmp.so - found (/usr/local/lib/libgmp.so)
===>   gcc6-6.4.0_7 depends on shared library: libmpfr.so - found (/usr/local/lib/libmpfr.so)
===>   gcc6-6.4.0_7 depends on shared library: libmpc.so - found (/usr/local/lib/libmpc.so)
Comment 7 Antoine Brodin freebsd_committer freebsd_triage 2018-07-29 09:21:06 UTC
It seems the change I reverted in base r333944 was applied again?
Comment 8 Eitan Adler freebsd_committer freebsd_triage 2018-07-29 09:22:33 UTC
let me check. I thought I reverted file and saw the same thing. Maybe some remnant of my testing remained.
Comment 9 Eitan Adler freebsd_committer freebsd_triage 2018-07-29 19:15:46 UTC
(a) Trying this with a clean file(1) shows the same thing: at first it tries to build gmp. Then it fails to install since gmp is already installed.
(B) Explicitly re-reverting that part of the patch changes nothing. I thought upstream had applied this already, so I didn't check for it at first. I'll upload a new diff with that part changed.

Is there an easy test to run that doesn't involve the ports tree? That might make it easier for me to ensure that everything is working without worrying about exactly what state my tree is in.
Comment 10 Eitan Adler freebsd_committer freebsd_triage 2018-07-29 19:16:11 UTC
Created attachment 195607 [details]
update file to 5.34
Comment 11 Antoine Brodin freebsd_committer freebsd_triage 2018-07-29 19:36:44 UTC
% file -b -L --mime-type /usr/local/lib/libgmp.so

If it doesn't say "application/x-sharedlib", there is a problem.
Comment 12 Eitan Adler freebsd_committer freebsd_triage 2018-08-02 07:13:52 UTC
Created attachment 195758 [details]
update file to 5.34

It seems obvious in retrospect but I forgot to reinstall libmagic as well..

∴$(make -V.OBJDIR)/file -b -L --mime-type /usr/local/lib/libgmp.so
application/x-sharedlib
Comment 13 Antoine Brodin freebsd_committer freebsd_triage 2018-08-07 07:21:56 UTC
Exp-run looks fine.
Comment 14 commit-hook freebsd_committer freebsd_triage 2018-08-08 01:34:06 UTC
A commit references this bug:

Author: eadler
Date: Wed Aug  8 01:33:37 UTC 2018
New revision: 337442
URL: https://svnweb.freebsd.org/changeset/base/337442

Log:
  file: update to 5.34

  PR:		230141
  exp-run by:	antoine

Changes:
_U  head/contrib/file/
  head/contrib/file/ChangeLog
  head/contrib/file/Makefile.in
  head/contrib/file/README
  head/contrib/file/aclocal.m4
  head/contrib/file/compile
  head/contrib/file/config.guess
  head/contrib/file/config.h.in
  head/contrib/file/config.sub
  head/contrib/file/configure
  head/contrib/file/configure.ac
  head/contrib/file/depcomp
  head/contrib/file/doc/Makefile.in
  head/contrib/file/doc/file.man
  head/contrib/file/doc/magic.man
  head/contrib/file/install-sh
  head/contrib/file/ltmain.sh
  head/contrib/file/magic/Magdir/animation
  head/contrib/file/magic/Magdir/archive
  head/contrib/file/magic/Magdir/audio
  head/contrib/file/magic/Magdir/cad
  head/contrib/file/magic/Magdir/console
  head/contrib/file/magic/Magdir/database
  head/contrib/file/magic/Magdir/dataone
  head/contrib/file/magic/Magdir/dbpf
  head/contrib/file/magic/Magdir/dump
  head/contrib/file/magic/Magdir/elf
  head/contrib/file/magic/Magdir/fsav
  head/contrib/file/magic/Magdir/images
  head/contrib/file/magic/Magdir/linux
  head/contrib/file/magic/Magdir/make
  head/contrib/file/magic/Magdir/measure
  head/contrib/file/magic/Magdir/msdos
  head/contrib/file/magic/Magdir/msooxml
  head/contrib/file/magic/Magdir/pdf
  head/contrib/file/magic/Magdir/sgi
  head/contrib/file/magic/Makefile.am
  head/contrib/file/magic/Makefile.in
  head/contrib/file/missing
  head/contrib/file/python/CHANGELOG.md
  head/contrib/file/python/LICENSE
  head/contrib/file/python/Makefile.am
  head/contrib/file/python/Makefile.in
  head/contrib/file/python/README
  head/contrib/file/python/README.md
  head/contrib/file/python/magic.py
  head/contrib/file/python/setup.py
  head/contrib/file/python/tests.py
  head/contrib/file/src/Makefile.in
  head/contrib/file/src/apprentice.c
  head/contrib/file/src/compress.c
  head/contrib/file/src/der.c
  head/contrib/file/src/file.h
  head/contrib/file/src/funcs.c
  head/contrib/file/src/readcdf.c
  head/contrib/file/src/readelf.c
  head/contrib/file/src/readelf.h
  head/contrib/file/src/seccomp.c
  head/contrib/file/src/softmagic.c
  head/contrib/file/tests/JW07022A.mp3.result
  head/contrib/file/tests/JW07022A.mp3.testfile
  head/contrib/file/tests/Makefile.am
  head/contrib/file/tests/Makefile.in