Bug 230205 - devel/lua-bitop: fix for 5.3+
Summary: devel/lua-bitop: fix for 5.3+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-30 23:20 UTC by Andrew "RhodiumToad" Gierth
Modified: 2018-08-15 19:35 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch (1.96 KB, patch)
2018-07-30 23:20 UTC, Andrew "RhodiumToad" Gierth 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew "RhodiumToad" Gierth 2018-07-30 23:20:13 UTC 
Created attachment 195662 [details]
Patch

Makefile contains incorrect -D option that compiles with 5.3, but causes incorrect runtime results.

This patch does two things: firstly it provides the correct option without causing warnings on 5.1/5.2 builds, and secondly it conditionally patches the distributed test scripts to compensate for different string conversions in 5.3. As a result, make test should now pass on all lua versions (tested 5.1-5.4)
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-08-15 19:34:40 UTC 
Committed. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-15 19:35:44 UTC 
A commit references this bug:

Author: sunpoet
Date: Wed Aug 15 19:34:19 UTC 2018
New revision: 477276
URL: https://svnweb.freebsd.org/changeset/ports/477276

Log:
  Fix CFLAGS and test

  - Bump PORTREVISION for package change

  PR:		230205
  Submitted by:	Andrew Gierth <andrew@tao11.riddles.org.uk>

Changes:
  head/devel/lua-bitop/Makefile
  head/devel/lua-bitop/files/
  head/devel/lua-bitop/files/extra-patch-bittest.lua