Bug 230365 - net-mgmt/statsite: Update to 0.8.0
Summary: net-mgmt/statsite: Update to 0.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/statsite/statsite/...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-04 22:14 UTC by Nathan
Modified: 2018-08-18 11:48 UTC (History)
1 user (show)

See Also:

Attachments
Update (3.94 KB, patch)
2018-08-04 22:14 UTC, Nathan 		no flags Details | Diff
Poudriere Log 10.4-Release (36.48 KB, text/plain)
2018-08-04 22:14 UTC, Nathan 		no flags Details
Poudriere Log 11.2-Stable (36.25 KB, text/plain)
2018-08-04 22:14 UTC, Nathan 		no flags Details
Update (4.79 KB, patch)
2018-08-04 22:25 UTC, Nathan 		no flags Details | Diff
Update (4.77 KB, patch)
2018-08-04 23:41 UTC, Nathan 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-08-04 22:14:07 UTC 
Created attachment 195861 [details]
Update

Changelog: https://github.com/statsite/statsite/blob/master/CHANGELOG.md
Portlint AC: ok
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2018-08-04 22:14:07 UTC 
Maintainer informed via mail
Comment 2 Nathan 2018-08-04 22:14:23 UTC 
Created attachment 195862 [details]
Poudriere Log 10.4-Release
Comment 3 Nathan 2018-08-04 22:14:40 UTC 
Created attachment 195863 [details]
Poudriere Log 11.2-Stable
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-04 22:21:07 UTC 
Comment on attachment 195861 [details]
Update

+USE_GCC=	yes

Why?


-PLIST_FILES=	bin/statsite
-
-do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/statsite ${STAGEDIR}/${PREFIX}/bin/
-

You have removed PLIST_FILES (why?) but the patch has no new pkg-plist.  This
cannot be right.
Comment 5 Nathan 2018-08-04 22:25:33 UTC 
Created attachment 195867 [details]
Update

Forgot to add pkg-plist file to svn and also removed gcc, as during build I seen ref to it and believed it to be needed
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-04 23:24:26 UTC 
Comment on attachment 195867 [details]
Update

+HAS_CONFIGURE=	yes

USES=autoreconf implies it's an autotools based build, so we should use
GNU_CONFIGURE=yes here. (Sorry, didn't see it before.)

+#USE_GCC=	yes

If it isn't needed remove it completely.  Generally we try to not keep
commented out variables in the Makefile.
Comment 7 Nathan 2018-08-04 23:41:14 UTC 
Created attachment 195871 [details]
Update
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-18 11:46:24 UTC 
Committed with some changes. Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-08-18 11:47:06 UTC 
A commit references this bug:

Author: tobik
Date: Sat Aug 18 11:46:07 UTC 2018
New revision: 477497
URL: https://svnweb.freebsd.org/changeset/ports/477497

Log:
  net-mgmt/statsite: Update to 0.8.0

  - While here install example config file and some actual documentation

  Changes:	https://github.com/statsite/statsite/blob/master/CHANGELOG.md
  PR:		230365
  Submitted by:	Nathan <ndowens@yahoo.com> (based on)
  Approved by:	maintainer timeout (2 weeks)

Changes:
  head/net-mgmt/statsite/Makefile
  head/net-mgmt/statsite/distinfo
  head/net-mgmt/statsite/pkg-plist
Comment 10 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-18 11:48:40 UTC 
As a followup idea for another PR: IMHO this port desperately needs an actual rc.d script.