Bug 230398 - net-im/telegram-desktop: update to 1.3.12
Summary: net-im/telegram-desktop: update to 1.3.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-06 00:03 UTC by Henry Hu
Modified: 2018-08-22 16:11 UTC (History)
2 users (show)

See Also:


Attachments
update to 1.3.12 (73.83 KB, patch)
2018-08-06 00:03 UTC, Henry Hu
henry.hu.sh: maintainer-approval+
Details | Diff
poudriere log on 11.1-STABLE/amd64 (96 bytes, text/plain)
2018-08-06 00:11 UTC, Henry Hu
no flags Details
poudriere log on 11.1-STABLE/i386 (95 bytes, text/plain)
2018-08-06 00:11 UTC, Henry Hu
no flags Details
updated patch with fix for 11.1 (71.63 KB, patch)
2018-08-20 20:23 UTC, Steve Wills
henry.hu.sh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2018-08-06 00:03:33 UTC
Created attachment 195922 [details]
update to 1.3.12

This patch updates telegram-desktop to 1.3.12 from 1.2.17.

A freebsd-specific repo is at github.com/HenryHu/tdesktop and github.com/HenryHu/libtgvoip. Now the workflow of importing a new version is:
1. create a new branch from last patched branch
2. git fetch upstream && git pull upstream <new version tag>
3. resolve conflicts & git commit
4. git diff <new version tag>..HEAD > new_patch
5. remove old patches
6. make extract
7. apply new_patch
8. make makepatch
9. test & fix problems. repeat steps 4..8

Steps 4..8 are implemented in sync-patch.sh in github.com/HenryHu/ports/net-im/telegram-desktop.

An option, GTK, is added. By default, telegram uses Gtk3 dialogs, even if under KDE, although it's a Qt5 program. Now, this behavior is disabled by default, and only enabled if the GTK option is set.

Changelog: https://desktop.telegram.org/changelog
Detailed changelog: https://github.com/telegramdesktop/tdesktop/blob/dev/changelog.txt

Noticeable changes:
- Added a new night theme. 
- You can now assign custom themes as night and day themes to quickly switch between them.  
- Mark chats in the chat list as Read or Unread.
- Improved censorship circumvention.
- Improved stability when working through proxy servers.
- Save several proxy servers to quickly switch between them in Settings.
- Use proxy for calls.
- Emoji and text replacement now happens immediately after typing (instead of after sending) and can be rolled back using Backspace or CTRL/CMD + Z. Replacement no longer happens when pasting text.
- Added formatting shortcuts. Select text and use:
- CTRL/CMD + B/I for bold and italic
- CTRL/CMD + K to create or edit a custom link
- CTRL/CMD + SHIFT + M for monospace font
- CTRL/CMD + SHIFT + N to clear formatting
- Apply markdown formatting (```, `, **, __) only when sending the message.
- Display connection quality bars in calls.
- Telegram Desktop can update itself through MTProto.
- Add links with custom text from context menu or by Ctrl/Cmd + K keyboard shortcut.
- Apply formatting from input field context menu.
- Apply formatting by hotkeys.
- Use markdown in media captions (**bold**, __italic__, `tag` and ```code```).
- Use emoji replacement in media captions, group and channel titles and descriptions (:like: etc.)
- Markdown replacement now happens immediately after typing (instead of after sending) and can be rolled back using Backspace or Ctrl/Cmd + Z. Replacement no longer happens when pasting text.
- Support domain names in mtproto proxy.
- Emoji and text replacements are done while you type the message.
- Revert emoji and text replacements by pressing backspace.
- Disable emoji replacements or suggestions in Settings.
- Enable proxy for calls in Settings.
- Improve working through proxy servers.
Comment 1 Henry Hu 2018-08-06 00:11:09 UTC
Created attachment 195923 [details]
poudriere log on 11.1-STABLE/amd64
Comment 2 Henry Hu 2018-08-06 00:11:32 UTC
Created attachment 195924 [details]
poudriere log on 11.1-STABLE/i386
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-08-15 18:30:52 UTC
For me, this didn't build on 11.1-RELEASE, with this error:

/wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-1.3.12/out/Release/../../Telegram/SourceFiles/base/bytes.h:117:23: error: call to 'make_span' is ambiguous
        details::spansAppend(make_span(result), args...);
                             ^~~~~~~~~

Did you see that?
Comment 4 Henry Hu 2018-08-20 01:25:23 UTC
(In reply to Steve Wills from comment #3)
No, I didn't.  I tried it again on poudriere in a 11.2-RELEASE jail, and it worked. I guess that changes in compiler/c++ library between 11.1-RELEASE and 11.2-RELEASE caused this.
make_span() is part of the GSL library. This patch updates the version of GSL used. Maybe that's the reason it worked in 11.1-RELEASE.
Comment 5 Steve Wills freebsd_committer freebsd_triage 2018-08-20 20:23:27 UTC
Created attachment 196399 [details]
updated patch with fix for 11.1

Here's an updated patch which adds a patch which fixes the build on 11.1. Look good?
Comment 6 Henry Hu 2018-08-21 03:30:00 UTC
Comment on attachment 196399 [details]
updated patch with fix for 11.1

Looks good. I tried it on both 11.1-RELEASE and 11.2-RELEASE and it's working fine.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-08-22 16:10:25 UTC
A commit references this bug:

Author: swills
Date: Wed Aug 22 16:09:52 UTC 2018
New revision: 477796
URL: https://svnweb.freebsd.org/changeset/ports/477796

Log:
  net-im/telegram-desktop: update to 1.3.12

  PR:		230398
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer)

Changes:
  head/net-im/telegram-desktop/Makefile
  head/net-im/telegram-desktop/distinfo
  head/net-im/telegram-desktop/files/CMakeLists.inj
  head/net-im/telegram-desktop/files/gyp-patches
  head/net-im/telegram-desktop/files/patch-Telegram_Resources_qrc_telegram__linux.qrc
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles___other_packer.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_build__config.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_bytes.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_lambda.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_boxes_notifications__box.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_config.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_launcher.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_update__checker.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_utils.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_data_data__document.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_export_data_export__data__types.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_admin__log_history__admin__log__inner.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_history__inner__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_view_history__view__list__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_layout.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_logs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_linux__libs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_linux__libs.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_main__window__linux.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__audio.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__file__utilities.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__launcher.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__main__window.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__notifications__manager.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__specific.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__window__title.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_qt__functions.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_qt__static__plugins.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_settings.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_settings_settings__notifications__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_text_text.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_text_text__block.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_twidget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_widgets_labels.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_window_main__window.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_window_main__window.h
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_VoIPController.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioIO.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioInput.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioOutput.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_logging.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioInputALSA.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioInputPulse.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioOutputALSA.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioOutputPulse.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioPulse.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_PulseAudioLoader.h
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_posix_NetworkSocketPosix.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_threading.h
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_webrtc__dsp_webrtc_base_stringutils.h
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_PrecompiledHeader.cmake
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_common.gypi
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_settings__linux.gypi
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_telegram__sources.txt
  head/net-im/telegram-desktop/files/patch-lib_xdg_tg.protocol
Comment 8 Steve Wills freebsd_committer freebsd_triage 2018-08-22 16:11:17 UTC
Committed, thanks!