Bug 230598 - textproc/docproj deal with WITH_SVN= knob in src.conf
Summary: textproc/docproj deal with WITH_SVN= knob in src.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sevan Janiyan
URL: https://reviews.freebsd.org/D16766
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-08-13 19:11 UTC by Dries Michiels
Modified: 2018-12-24 01:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (doceng)

Attachments
Fix to deal with src.conf knob WITH_SVN= (980 bytes, patch)
2018-08-13 19:11 UTC, Dries Michiels 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels freebsd_committer freebsd_triage 2018-08-13 19:11:34 UTC 
Created attachment 196167 [details]
Fix to deal with src.conf knob WITH_SVN=

Prefer svn binary in base if installed as /usr/bin/svnlite or /usr/bin/svn.
Also reference svn bninary from ports support as ${LOCALBASE} to prevent malicious dependency linking with /usr/bin/svn when present.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-12-24 01:46:13 UTC 
A commit references this bug:

Author: sevan
Date: Mon Dec 24 01:45:25 UTC 2018
New revision: 488249
URL: https://svnweb.freebsd.org/changeset/ports/488249

Log:
  Cater for systems built WITH_SVN knob

  PR:		230598
  Submitted by:	Dries Michiels < driesm.michiels AT gmail >
  Approved by:	bcr (doceng)
  Differential Revision:	https://reviews.freebsd.org/D16766

Changes:
  head/textproc/docproj/Makefile
Comment 2 Sevan Janiyan freebsd_committer freebsd_triage 2018-12-24 01:47:21 UTC 
Thank you for the patch & apologies for the delay. It's now committed.