Bug 230605 - lang/python37: Remove THREADS option (no longer optional: fails to configure)
Summary: lang/python37: Remove THREADS option (no longer optional: fails to configure)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2018-08-13 21:58 UTC by rsmith
Modified: 2018-08-26 18:43 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (python)


Attachments
Remove threads option. (1.12 KB, patch)
2018-08-13 21:58 UTC, rsmith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2018-08-13 21:58:43 UTC
Created attachment 196170 [details]
Remove threads option.

During compilation of lang/python37 I got the following warning:

    configure: WARNING: unrecognized options: --with-threads

According to https://docs.python.org/3/whatsnew/3.7.html:

    Support for building --without-threads has been removed.
    The threading module is now always available.
    (Contributed by Antoine Pitrou in bpo-31370.).

So attached is a patch for the port Makefile to remove the THREADS option. I also moved PORTREVISION to pet portlint.

It builds OK. Portlint is gives no errors, just some warnings.

(Python 37 won't package for me because of bug 229562.)
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-08-26 18:42:49 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Aug 26 18:42:38 UTC 2018
New revision: 478157
URL: https://svnweb.freebsd.org/changeset/ports/478157

Log:
  Remove THREADS option

  - Bump PORTREVISION for package change

  Support for building --without-threads has been removed.
  The threading module is now always available.

  PR:		230605
  Submitted by:	Roland Smith <rsmith@xs4all.nl>
  Reference:	https://docs.python.org/3/whatsnew/3.7.html

Changes:
  head/lang/python37/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-08-26 18:43:15 UTC
Committed. Thanks!