Bug 230719 - net/packetdrill: update to August 2018
Summary: net/packetdrill: update to August 2018
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-17 22:17 UTC by Kevin Bowling
Modified: 2018-09-04 21:55 UTC (History)
5 users (show)

See Also:
kbowling: maintainer-feedback+


Attachments
packetdrill august 2018 (1.21 KB, patch)
2018-08-17 22:17 UTC, Kevin Bowling
no flags Details | Diff
packetdrill august 2018 (1.20 KB, patch)
2018-08-20 03:43 UTC, Kevin Bowling
no flags Details | Diff
packetdrill august 2018 (1.29 KB, patch)
2018-08-23 07:47 UTC, Kevin Bowling
kbowling: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Bowling freebsd_committer freebsd_triage 2018-08-17 22:17:19 UTC
Created attachment 196300 [details]
packetdrill august 2018

The nplab repo contains everything freebsd-net had plus a lot of recent fixes from Tuexen especially wrt big endian machines.
Comment 1 Michael Tuexen freebsd_committer freebsd_triage 2018-08-19 09:12:00 UTC
I merged all changes from the NPLab version into the FreeBSD-Net version:
https://github.com/freebsd-net/packetdrill/commit/d449b3253d83ae7347e53921dc6040e29e1bf2a0

So using the latest version from FreeBSD-Net on GitHub is fine.
Comment 2 Kevin Bowling freebsd_committer freebsd_triage 2018-08-20 03:43:17 UTC
Created attachment 196370 [details]
packetdrill august 2018

Pivot back to freebsd-net with latest commits
Comment 3 Kevin Bowling freebsd_committer freebsd_triage 2018-08-23 03:05:27 UTC
(In reply to Michael Tuexen from comment #1)

Michael, I talked to gnn about this and he suggests transitioning ownership.  Are you ok with becoming the port maintainer as part of this diff?  Otherwise I am happy to take it.
Comment 4 Michael Tuexen freebsd_committer freebsd_triage 2018-08-23 07:38:37 UTC
(In reply to Kevin Bowling from comment #3)
Since I don't have a ports commit bit, I can't do more then provide feedback when a good point for an update is. So please go ahead and take the ownership...
Comment 5 Kevin Bowling freebsd_committer freebsd_triage 2018-08-23 07:47:00 UTC
Created attachment 196468 [details]
packetdrill august 2018

Take ownership per IRC communication with gnn and note from tuexen@ above.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-09-04 21:54:30 UTC
A commit references this bug:

Author: kbowling
Date: Tue Sep  4 21:54:22 UTC 2018
New revision: 478992
URL: https://svnweb.freebsd.org/changeset/ports/478992

Log:
  net/packetdrill: Take port maintainership and update

  PR:		230719
  Reviewed by:	tuexen
  Approved by:	timur (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17024

Changes:
  head/net/packetdrill/Makefile
  head/net/packetdrill/distinfo