Bug 230978 - security/zxid: Take MAINTAINER'ship and fix memory leak
Summary: security/zxid: Take MAINTAINER'ship and fix memory leak
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-08-28 14:34 UTC by Andres Montalban
Modified: 2018-09-01 07:50 UTC (History)
3 users (show)

See Also:
riggs: merge-quarterly+


Attachments
zxid.patch (5.60 KB, patch)
2018-08-28 14:34 UTC, Andres Montalban
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Montalban 2018-08-28 14:34:38 UTC
Created attachment 196646 [details]
zxid.patch

Hi guys,

I'm submitting this patch for two things:

1) Fix a memory leak in ZXID caused by using system hexdump() function instead of the one included in ZXID.

2) Take MAINTAINER'ship of this package as we use it in our company.

Disclaimer: This work has been done by my coworker (Felipe Zipitria) at [1], I just build this patch so it's available for all FreeBSD users.

Thanks,
Andres

--

[1] https://github.com/Perceptyx/zxid/commit/134123eb2355226f56d2c5d9f6ea2095906f3f05
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-09-01 07:35:50 UTC
A commit references this bug:

Author: riggs
Date: Sat Sep  1 07:35:30 UTC 2018
New revision: 478658
URL: https://svnweb.freebsd.org/changeset/ports/478658

Log:
  Fix memleak, update MAINTAINER

  Details:
  - Fix a memory leak in ZXID caused by using system hexdump() function
    instead of the one included in ZXID.
  - Set MAINTAINER'ship to admins@perceptyx.com

  PR:		230978
  Submitted by:	amontalban@gmail.com (new maintainer)
  MFH:		2018Q3

Changes:
  head/security/zxid/Makefile
  head/security/zxid/files/patch-errmac.h
  head/security/zxid/files/patch-zxsig.c
  head/security/zxid/files/patch-zxutil.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-01 07:40:56 UTC
A commit references this bug:

Author: riggs
Date: Sat Sep  1 07:40:29 UTC 2018
New revision: 478659
URL: https://svnweb.freebsd.org/changeset/ports/478659

Log:
  MFH: r478658

  Fix memleak, update MAINTAINER

  Details:
  - Fix a memory leak in ZXID caused by using system hexdump() function
    instead of the one included in ZXID.
  - Set MAINTAINER'ship to admins@perceptyx.com

  PR:		230978
  Submitted by:	amontalban@gmail.com (new maintainer)

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/security/zxid/Makefile
  branches/2018Q3/security/zxid/files/patch-errmac.h
  branches/2018Q3/security/zxid/files/patch-zxsig.c
  branches/2018Q3/security/zxid/files/patch-zxutil.c
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2018-09-01 07:50:44 UTC
Committed, thanks.

For future submissions, don't forget to mention that you are behind the admin@... e-mail address, otherwise it might be confusing for the next committer that submitter and maintainer address are different.

Also, automated bug reports will go to the admin@... address, please ensure that you are reachable via this address.