Created attachment 196907 [details] Strip libraries; add ssl Outside of poudriere with flavor py36 I got errors of *.so files not been stripped and it gave also that USES=ssl was needed
Thank you for the submission, Nathan. I expect to be able to review your patch and give feedback or approval this weekend.
Created attachment 197144 [details] security/py-gssapi: Strip shared objects, use ssl when needed Nathan, I've revised your patch as follows. * Before patching, poudriere testport only emits the USES=ssl warning if GSSAPI_BASE is selected. With your patch, it no longer warns on GSSAPI_BASE, but does emit "Warning: you may not need USES=ssl" on both other GSSAPI options. Therefore I moved "ssl" from the general USES to GSSAPI_BASE_USES. Could you please confirm that this also works for you? * I would prefer to avoid the sub-shell + cd pattern in this case. There is no benefit to setting the CWD on behalf of the subsequent work---as there would be for running a test suite, for instance---so stripping in three steps instead of one just adds complexity, and is more likely to increase the scope of future diffs. While here, I parameterize the package directory.
(In reply to John W. O'Brien from comment #2) Looks good to me
I'm not sure what the significance is of marking the whole bug "maintainer-feedback+" after I've already marked an attached patch "maintainer-approval+", but bugzilla seems to want me to do that.
Committed, thanks!
A commit references this bug: Author: pi Date: Sun Nov 11 08:33:47 UTC 2018 New revision: 484665 URL: https://svnweb.freebsd.org/changeset/ports/484665 Log: security/py-gssapi: Strip libraries; add ssl PR: 231189 Submitted by: ndowens@yahoo.com Approved by: John W. O'Brein <john@saltant.com> (maintainer) Changes: head/security/py-gssapi/Makefile