Created attachment 197205 [details] patch updates databases/pgadmin3 to 1.22.2 This patch updates databases/pgadmin3 from version 1.22.1 to 1.22.2. There are only some smaller changes in the sources: - Include the Negator when reverse engineering SQL for operators - Fix the psql plugin command on OSX to work more reliably - Allow multiple SQL editor tabs to be used in the query tool - Prevent a crash in some situtions where the database connection is lost and needs to be reset. - Fix display of elapsed query time for queries running longer than 1 hour The port also - corrects the mastersite - updates the patch for plugins.d/plugins.ini Poudriere builds (HEADa/i, 11.2a/i) seem to be ok. portlint -AC only make some suggestions: WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. WARN: Makefile: CXXFLAGS is overridden in the Makefile clobbering a value possibly set by a user. Consider using CXXFLAGS+=... if you want to add or CXXFLAGS:=${CXXFLAGS:C/...//} if you want to remove specific flags WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: you may want directory for dependency sphinx-build to be textproc/py-sphinx@${PY_FLAVOR} WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 5 warnings found.
⇒ svn patch /home/ndowens/Patches/pgadmin3 C pgadmin3/Makefile > rejected hunk @@ -2,10 +2,9 @@ C pgadmin3/distinfo > rejected hunk @@ -1,2 +1,3 @@ C pgadmin3/files/patch-plugins.d-plugins.ini > rejected hunk @@ -1,6 +1,33 @@ Summary of conflicts: Text conflicts: 3
(In reply to Nathan from comment #1) Cancel that, patch -p0 works
Need to add gnome to USES Also see: bug#225953 You may could add OPENSSL to options: DEFINE_OPTIONS= OPENSSL OPTIONS_DEFAULT= OPENSSL OPENSSL_USES= ssl Package contains other options that you may consider adding to it. Doing atleast the above could close the other bug
Created attachment 197224 [details] integrate USES=gnome and OPTION openssl Hi Nathan, Thanks for taking the PR and your suggestions. I only integrated USES=gnome and the openssl option. pgAdmin3 is no longer maintained[1] and the intention of this update is to bypass at least the time remaining since pgAdmin4 is in the ports tree. [1] https://www.postgresql.org/ftp/pgadmin/
Comment on attachment 197224 [details] integrate USES=gnome and OPTION openssl Note to committer: Patch includes support for SSL to satisfy/close PR: 225953
The patch for plugins.d is not required (it is done using REINPLACE_CMD)
A commit references this bug: Author: fjoe Date: Tue Dec 11 12:58:28 UTC 2018 New revision: 487234 URL: https://svnweb.freebsd.org/changeset/ports/487234 Log: - Update to 1.22.2 - Add explicit missing dependency on SSL - Fix portlint warnings PR: 231454, 225953 Submitted by: Rainer Hurling, Bernard Spil Changes: head/databases/pgadmin3/Makefile head/databases/pgadmin3/distinfo
Explicit dependency on GNOME is also not required as the port depends only on wxWidgets.