Bug 231649 - "pw useradd -D -w random" does not edit pw.conf
Summary: "pw useradd -D -w random" does not edit pw.conf
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Pankov
URL: https://reviews.freebsd.org/D17299
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-24 02:20 UTC by Victor Sudakov
Modified: 2024-01-10 07:20 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2018-09-24 02:20:23 UTC 
How to reproduce:

[root@adm2 ~] grep defaultpasswd /etc/pw.conf
defaultpasswd = "yes"
[root@adm2 ~] pw useradd -D -w random
[root@adm2 ~] grep defaultpasswd /etc/pw.conf
defaultpasswd = "yes"
[root@adm2 ~]
Comment 1 Yuri Pankov 2018-09-24 03:50:33 UTC 
review D17299.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-21 14:24:04 UTC 
A commit references this bug:

Author: yuripv
Date: Sun Oct 21 14:23:57 UTC 2018
New revision: 339534
URL: https://svnweb.freebsd.org/changeset/base/339534

Log:
  pw: fix the checks in boolean_str() after r326738.  Add related test
  cases for `pw useradd -D -w`.

  PR:		231649
  Reviewed by:	eugen
  Approved by:	kib (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17299

Changes:
  head/usr.sbin/pw/pw_conf.c
  head/usr.sbin/pw/tests/pw_useradd_test.sh
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2024-01-10 07:20:19 UTC 
^Triage: fixed back in 2018.