Bug 231853 - [patch] multimedia/smplayer-skins: rebuild with Qt5, take maintainership
Summary: [patch] multimedia/smplayer-skins: rebuild with Qt5, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on: 231856
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-01 14:26 UTC by kikadf
Modified: 2018-10-21 17:39 UTC (History)
1 user (show)

See Also:
riggs: maintainer-feedback+

Attachments
patch (674 bytes, patch)
2018-10-01 14:26 UTC, kikadf 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kikadf 2018-10-01 14:26:50 UTC 
Created attachment 197677 [details]
patch

Take maintainership, rebuild with Qt5 instead of Qt4.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2018-10-14 08:13:30 UTC 
Does it make sense to have smplayer-skins use qt5 exclusively?
smplayer defaults to qt4 and the toolkit can be set via OPTIONS. For consistent building and packaging, smplayer and smplayer-skins should do the same.
Comment 2 kikadf 2018-10-14 10:58:36 UTC 
(In reply to Thomas Zander from comment #1)
I opened a bug to bump smplayer version and use Qt5 as default.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231856

Should  I set that bug as depend of this? 

I opened another smplayer relevant bug too, bump smplayer-themes:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231854

Thanks your review.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-21 17:35:50 UTC 
A commit references this bug:

Author: riggs
Date: Sun Oct 21 17:35:06 UTC 2018
New revision: 482713
URL: https://svnweb.freebsd.org/changeset/ports/482713

Log:
  Default toolkit is now QT5, new maintainer

  PR:		231853
  Submitted by:	kikadf.01@gmail.com (new maintainer)

Changes:
  head/multimedia/smplayer-skins/Makefile