Bug 231861 - textproc/qt5-xmlpatterns: fix build on GCC-based architectures
Summary: textproc/qt5-xmlpatterns: fix build on GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on: 231963
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-01 16:51 UTC by Piotr Kubaj
Modified: 2018-10-20 16:41 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
patch (511 bytes, patch)
2018-10-01 16:51 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-01 16:51:33 UTC
Created attachment 197688 [details]
patch

Similar to others, requires adding USES=compiler:c++17-lang.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2018-10-01 20:22:19 UTC
Looks good to me. But shouldn't these all depend on the qt.mk, aka devel/qt5-qmake one?
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-01 23:18:59 UTC
(In reply to Tobias C. Berner from comment #1)
To really get this fixed on e.g. powerpc64, they depend on qt-dist.mk patch.

That said, I don't want to block committing those fixes before qt-dist.mk patch, since they do no harm on amd64 and still fix it when qt-dist.mk is patched.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-14 08:03:45 UTC
A commit references this bug:

Author: tcberner
Date: Sun Oct 14 08:01:27 UTC 2018
New revision: 482034
URL: https://svnweb.freebsd.org/changeset/ports/482034

Log:
  qt5: Fix build on GCC based architectures.

  PR:		231584
  PR:		231677
  PR:		231685
  PR:		231830
  PR:		231955
  PR:		231905
  PR:		231892
  PR:		231684
  PR:		231958
  PR:		231960
  PR:		231818
  PR:		231542
  PR:		231860
  PR:		231681
  PR:		231963
  PR:		231891
  PR:		231966
  PR:		231904
  PR:		231676
  PR:		231819
  PR:		231956
  PR:		231680
  PR:		231957
  PR:		231903
  PR:		231901
  PR:		231667
  PR:		231861
  Submitted by:	 Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/Mk/Uses/qt-dist.mk
  head/accessibility/qt5-speech/Makefile
  head/comms/qt5-sensors/Makefile
  head/comms/qt5-serialport/Makefile
  head/databases/qt5-sql/Makefile
  head/devel/qt5/Makefile.sqldrivers
  head/devel/qt5/files/extra-patch-mkspecs_common_g++-base.conf
  head/devel/qt5/files/extra-patch-mkspecs_common_gcc-base.conf
  head/devel/qt5-assistant/Makefile
  head/devel/qt5-buildtools/Makefile
  head/devel/qt5-concurrent/Makefile
  head/devel/qt5-core/Makefile
  head/devel/qt5-dbus/Makefile
  head/devel/qt5-designer/Makefile
  head/devel/qt5-help/Makefile
  head/devel/qt5-linguisttools/Makefile
  head/devel/qt5-location/Makefile
  head/devel/qt5-qdbus/Makefile
  head/devel/qt5-qmake/Makefile
  head/devel/qt5-script/Makefile
  head/devel/qt5-scripttools/Makefile
  head/devel/qt5-testlib/Makefile
  head/devel/qt5-uitools/Makefile
  head/graphics/qt5-imageformats/Makefile
  head/graphics/qt5-opengl/Makefile
  head/graphics/qt5-svg/Makefile
  head/lang/qt5-qml/Makefile
  head/multimedia/qt5-multimedia/Makefile
  head/net/qt5-network/Makefile
  head/print/qt5-printsupport/Makefile
  head/sysutils/qt5-qtpaths/Makefile
  head/textproc/qt5-xml/Makefile
  head/textproc/qt5-xmlpatterns/Makefile
  head/www/qt5-webchannel/Makefile
  head/x11/qt5-x11extras/Makefile
  head/x11-toolkits/qt5-gui/Makefile
  head/x11-toolkits/qt5-quick/Makefile
  head/x11-toolkits/qt5-quickcontrols/Makefile
  head/x11-toolkits/qt5-quickcontrols2/Makefile
  head/x11-toolkits/qt5-virtualkeyboard/Makefile
  head/x11-toolkits/qt5-widgets/Makefile