Bug 231918 - net/flower: require C++17-compatible compiler
Summary: net/flower: require C++17-compatible compiler
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-03 15:30 UTC by Piotr Kubaj
Modified: 2018-10-28 16:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ed)

Attachments
patch (369 bytes, patch)
2018-10-03 15:30 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-03 15:30:26 UTC 
Created attachment 197754 [details]
patch

This port uses C++17, but doesn't say it in Makefile, which breaks build on architectures that still use GCC. It also probably breaks build on 10-STABLE.

Fix it by adding USES=compiler:c++17-lang.

Tested on powerpc64 and amd64.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-10-28 16:09:24 UTC 
A commit references this bug:

Author: linimon
Date: Sun Oct 28 16:08:49 UTC 2018
New revision: 483311
URL: https://svnweb.freebsd.org/changeset/ports/483311

Log:
  This port uses C++17, but doesn't define it, which breaks build on
  architectures that still use GCC.

  PR:		231918
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/net/flower/Makefile