State Changed From-To: open->closed Committed, thanks! Next time remember to make your shars properly so they create the port's directory first. It would be nice if there was a patch to make this program use getopt() instead of hardcoding the long/lat into it.
>Submitter-Id: current-users >Originator: Keith Walker >Organization: >Confidential: no >Synopsis: Fix to Makefile to clear up hardwired lat/longs >Severity: non-critical >Priority: low >Category: ports >Release: FreeBSD 4.2-STABLE i386 >Class: change-request >Environment: current ports >Description: This patch makes it clear that the program has always been able to accept latitude and longitude via the command line. >How-To-Repeat: >Fix: diff -ur sscalc-master/Makefile sscalc/Makefile --- sscalc-master/Makefile Tue Dec 19 05:36:31 2000 +++ sscalc/Makefile Thu Dec 21 07:17:18 2000 @@ -2,7 +2,7 @@ # Date created: Wed Nov 29 15:08:00 PST 2000 # Whom: Keith Walker <kew@icehouse.net> # -# $FreeBSD: ports/astro/sscalc/Makefile,v 1.1 2000/12/19 13:36:31 will Exp $ +# $FreeBSD$ # PORTNAME= sscalc @@ -14,9 +14,14 @@ pre-fetch: .if !defined(LAT) - @${ECHO_MSG} "Type \"make LAT=<nnn.nn> LON=<nnn.nn>\" to hardwire your site" + @${ECHO} "*****************************************************************" + @${ECHO} "While you can ALWAYS provide the lat/longs via the command" + @${ECHO} "line, you can choose to hardwire the coordinates to ease" + @${ECHO} "things a bit:" + @${ECHO} " use \"make LAT=<nnn.nn> LON=<nnn.nn>\" if you want to." + @${ECHO} "*****************************************************************" .else - @${ECHO_MSG} "Compiling in lat/longs" + @${ECHO} "Compiling in lat/longs" .endif post-install: @@ -24,5 +29,11 @@ @${MKDIR} ${PREFIX}/share/doc/sscalc ${INSTALL_DATA} ${WRKSRC}/cities.txt ${PREFIX}/share/doc/sscalc ${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/sscalc + @${ECHO} "*****************************************************************" + @${ECHO} " Located in ${PREFIX}/share/doc/sscalc/cities.txt is a list" + @${ECHO} " of lat/longs for many, many cities all over the globe." + @${ECHO} " You may be able to find your town in that file if you don't" + @${ECHO} " know your latitude and longitude." + @${ECHO} "*****************************************************************" .include <bsd.port.mk>
On Thu, Dec 21, 2000 at 08:00:03AM -0800, kew@icehouse.net wrote: > This patch makes it clear that the program has always been > able to accept latitude and longitude via the command line. :-) As you wish. :-) -- wca