Bug 232646 - mail/milter-callback: fix build with GCC-based architectures
Summary: mail/milter-callback: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 17:15 UTC by Piotr Kubaj
Modified: 2018-10-26 14:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
patch (960 bytes, patch)
2018-10-24 17:15 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 17:15:05 UTC 
Created attachment 198584 [details]
patch

GCC architectures require CFLAGS+=-fnested-functions.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2018-10-26 11:20:02 UTC 
Would 

USES=compiler:nestedfct

suffice?
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-26 12:22:51 UTC 
This USES addition is certainly useful to make sure that proper compiler is used, but CFLAGS mod is still needed:
===>  Building for milter-callback-1.6.0_6
gcc -O2 -pipe  -DFREEBSD -DHAVE_NS_TYPE -DWITH_SPF -I/usr/local/include -I/tmp/usr/local/poudriere/ports/default/mail/milter-callback/work/milter-callback-1.6.0 -std=gnu99 -fno-strict-aliasing  -c /tmp/usr/local/poudriere/ports/default/mail/milter-callback/work/milter-callback-1.6.0/cache.c -o /tmp/usr/local/poudriere/ports/default/mail/milter-callback/work/milter-callback-1.6.0/cache.o
/tmp/usr/local/poudriere/ports/default/mail/milter-callback/work/milter-callback-1.6.0/cache.c: In function 'extendCache':
/tmp/usr/local/poudriere/ports/default/mail/milter-callback/work/milter-callback-1.6.0/cache.c:338: error: nested functions are disabled, use -fnested-functions to re-enable
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-26 14:41:14 UTC 
A commit references this bug:

Author: ehaupt
Date: Fri Oct 26 14:40:55 UTC 2018
New revision: 483035
URL: https://svnweb.freebsd.org/changeset/ports/483035

Log:
  Fix build with GCC-based architectures. GCC architectures require
  CFLAGS+=-fnested-functions.

  PR:		232646
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>
  MFH:		2018Q4 (blanket)

Changes:
  head/mail/milter-callback/Makefile
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2018-10-26 14:43:16 UTC 
Committed, thanks.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-10-26 14:43:18 UTC 
A commit references this bug:

Author: ehaupt
Date: Fri Oct 26 14:42:24 UTC 2018
New revision: 483037
URL: https://svnweb.freebsd.org/changeset/ports/483037

Log:
  MFH: r483035

  Fix build with GCC-based architectures. GCC architectures require
  CFLAGS+=-fnested-functions.

  PR:		232646
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>
  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2018Q4/
  branches/2018Q4/mail/milter-callback/Makefile