The following command fails: # ipfw table 1 create type number ipfw: Table creation failed: Operation not supported The following one works: # ipfw table 1 create type number algo number:array Please fix algo defaults to be sane and depend of table type.
Fix Assignee to rightful author of the code in question.
Problem still occurs
Created attachment 222815 [details] proposed patch Can you test this patch?
(In reply to Andrey V. Elsukov from comment #3) I've just tested it with my 11.4-STABLE/amd64 workstation. The patch works just fine, please commit.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=13ad237a19b7368124483d9d1dc3258c27880fef commit 13ad237a19b7368124483d9d1dc3258c27880fef Author: Andrey V. Elsukov <ae@FreeBSD.org> AuthorDate: 2021-02-25 13:57:47 +0000 Commit: Andrey V. Elsukov <ae@FreeBSD.org> CommitDate: 2021-02-25 13:57:47 +0000 ipfw: make algo name argument optional for some table types Most of table types currently supported by ipfw have only one algorithm implementation. When user creates such tables, allow to omit algo name in arguments. E.g. now it is possible: ipfw table T1 create type number ipfw table T2 create type iface ipfw table T3 create type flow PR: 233072 MFC after: 1 week Sponsored by: Yandex LLC sbin/ipfw/tables.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=8d0f1438b0d73dfa880cfafc5d09beb4e7100a3f commit 8d0f1438b0d73dfa880cfafc5d09beb4e7100a3f Author: Andrey V. Elsukov <ae@FreeBSD.org> AuthorDate: 2021-02-25 13:57:47 +0000 Commit: Andrey V. Elsukov <ae@FreeBSD.org> CommitDate: 2021-03-04 09:19:31 +0000 ipfw: make algo name argument optional for some table types Most of table types currently supported by ipfw have only one algorithm implementation. When user creates such tables, allow to omit algo name in arguments. E.g. now it is possible: ipfw table T1 create type number ipfw table T2 create type iface ipfw table T3 create type flow PR: 233072 Sponsored by: Yandex LLC (cherry picked from commit 13ad237a19b7368124483d9d1dc3258c27880fef) sbin/ipfw/tables.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=f8317f3a4c7dc01438328edd21c984d794286ec5 commit f8317f3a4c7dc01438328edd21c984d794286ec5 Author: Andrey V. Elsukov <ae@FreeBSD.org> AuthorDate: 2021-02-25 13:57:47 +0000 Commit: Andrey V. Elsukov <ae@FreeBSD.org> CommitDate: 2021-03-04 09:21:28 +0000 ipfw: make algo name argument optional for some table types Most of table types currently supported by ipfw have only one algorithm implementation. When user creates such tables, allow to omit algo name in arguments. E.g. now it is possible: ipfw table T1 create type number ipfw table T2 create type iface ipfw table T3 create type flow PR: 233072 Sponsored by: Yandex LLC (cherry picked from commit 13ad237a19b7368124483d9d1dc3258c27880fef) sbin/ipfw/tables.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
A commit in branch stable/11 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=952ad28223596ef4e323a9a7da81ef3faf1c919a commit 952ad28223596ef4e323a9a7da81ef3faf1c919a Author: Andrey V. Elsukov <ae@FreeBSD.org> AuthorDate: 2021-02-25 13:57:47 +0000 Commit: Andrey V. Elsukov <ae@FreeBSD.org> CommitDate: 2021-03-04 09:23:01 +0000 ipfw: make algo name argument optional for some table types Most of table types currently supported by ipfw have only one algorithm implementation. When user creates such tables, allow to omit algo name in arguments. E.g. now it is possible: ipfw table T1 create type number ipfw table T2 create type iface ipfw table T3 create type flow PR: 233072 Sponsored by: Yandex LLC (cherry picked from commit 13ad237a19b7368124483d9d1dc3258c27880fef) sbin/ipfw/tables.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
Fixed in head, stable/13, stable/12 and stable/11. Thanks!
MARKED AS SPAM