Created attachment 199404 [details] shar archive for updated chkascii This is an update for the initial release of the new port chkascii : https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233254 The app now shows 2-d coordinates of bad ASCII value. The man page mentions hexedit. For clarity, the version of this update has been incremented to 1.1
Created attachment 199405 [details] shar archive for updated chkascii (Attempt# 2) Minor fix in man page version (1.0 -> 1.1)
Please follow the instructions from the porter's handbook: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html
Created attachment 199421 [details] shar archive for updated chkascii (Attempt# 3) Makefile now has LICENSE_FILE
Created attachment 199422 [details] Diff to be applied for chkascii 1.0 to update to version 1.1
Fix Synopsis. fwiw I don't see the change to the LICENSE_FILE in the Makefile.
Hi Mark, My Makefile has this (if I am not mistaken): LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/LICENSE Is that not enough ? The actual file LICENSE is hosted at the GitHub repo. Please let me know if you need me to make any changes. I could not understand what you mean by 'Fix Synopsis'. Kindly elaborate. Thanks. Manish Jain
Created attachment 199750 [details] shar archive for updated chkascii (Attempt# 4) shar archive for updated chkascii now enhanced for printing summary (--summary).
Created attachment 199751 [details] Diff to be applied for chkascii 1.0 to update to version 1.2
Created attachment 199752 [details] shar archive for updated chkascii (Attempt# 5) Minor fix over Attempt# 4
Created attachment 199753 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 5)
Created attachment 199754 [details] shar archive for updated chkascii (Attempt# 6) Another minor fix -- multiple --accept parameters disabled
Created attachment 199755 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 6)
Created attachment 199756 [details] shar archive for updated chkascii (Attempt# 7) Yet another minor fix
Created attachment 199757 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 7)
Comment on attachment 199756 [details] shar archive for updated chkascii (Attempt# 7) .shar format is only optionally used for new (uncommitted) ports. After creation, port updates are to be provided in unified diff formatted patches.
Hi Kubilay, Thanks for reverting. I anyway like to upload the shar as well (along with the diff). I hope that is okay with you. If not, please let me know. Is the port now good enough for a commit ? If yes, I request the needed action for a commit. Thanks. Manish Jain
Created attachment 199785 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 8) Contains fix (exit code 1 -> -1)
Created attachment 199786 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 9) A fix for exit code remained to be applied in included headers. Now done.
Created attachment 199830 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 10) Removed an unnecessary declaration
Created attachment 199928 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 11) A minor fix in the app was needed. I think the port is now final.
Created attachment 199929 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 12) Yet another minor fix popped up -- inconsistent header guard names. The port is now final.
Created attachment 199933 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 13) Bug (programming error) spotted in app. Now fixed. The port is now final.
Created attachment 199934 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 14) Inserted a missing assertion.
Created attachment 199943 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 15) Minor improvements in app as well as doc. Request committers to please proceed with a commit. Any further changes can be aggregated into the next point release. Thanks. Manish Jain
Created attachment 199944 [details] Diff to be applied for chkascii 1.0 to update to version 1.2 (Attempt# 16) Heap memory for linked list now being explicitly released.
Thanks, I'm now waiting for the approval to commit: https://reviews.freebsd.org/D18524
Committed! Thank you!
A commit references this bug: Author: 0mp Date: Wed Dec 12 14:33:44 UTC 2018 New revision: 487298 URL: https://svnweb.freebsd.org/changeset/ports/487298 Log: textproc/chkascii: Update to 1.2 PR: 233370 Submitted by: bourne.identity@hotmail.com (maintainer) Approved by: krion (mentor) Differential Revision: https://reviews.freebsd.org/D18524 Changes: head/textproc/chkascii/Makefile head/textproc/chkascii/distinfo
Assign to committer that resolved
Kubilay / Mateusz, Thanks so much for what you have done. I am having a beer for the success of our combined effort. Please do try my other port mkdesktop in 2019 (right now it only among ports, not pkg). Regards, Manish Jain