Bug 233568 - devel/gdcm: properly define USES
Summary: devel/gdcm: properly define USES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-27 15:55 UTC by Piotr Kubaj
Modified: 2018-11-27 23:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (stephen)


Attachments
patch (610 bytes, patch)
2018-11-27 15:55 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-11-27 15:55:56 UTC
Created attachment 199605 [details]
patch

There are two definitions of USES, with the 2nd one overwriting the 1st one, breaking build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2018-11-27 16:00:30 UTC
Just a small correction, while gdcm itself builds with base GCC, science/InsightToolkit needs gdcm to be linked using newer compiler than current base GCC.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-11-27 23:04:30 UTC
A commit references this bug:

Author: stephen
Date: Tue Nov 27 23:04:07 UTC 2018
New revision: 486072
URL: https://svnweb.freebsd.org/changeset/ports/486072

Log:
  - Combine the two USES together - one used to incorrectly over-right the other.

  PR:		ports/233568
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/devel/gdcm/Makefile
Comment 3 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2018-11-27 23:05:26 UTC
Committed.  Thank you very much.