Created attachment 200097 [details] new port Exscript is a Python module and a template processor for automating network connections over protocols such as Telnet or SSH. We attempt to create the best possible set of tools for working with Telnet and SSH. WWW: https://github.com/knipknap/exscript
Comment on attachment 200097 [details] new port +GH_PROJECT= exscript Just so you know, if GH_ACCOUNT or GH_PROJECT is the same as PORTNAME, no need to specify; nothing major. *_DEPENDS goes below LICENSE (with space between), then USES, followed by USE_* See: https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html +COMMENT= https://github.com/knipknap/exscript Needs to be a short description(not containing portname), not URL
Review items: * The canonical version scheme is x.y.z (per PyPI release), current version is 2.6.2. Update PORTVERSION accordingly. The repo does not contain a tag for this version, ask them to create one. Identify the exact revision of the 2.6.2 release and use that, if its not the same as the one already provided. * Add a # comment above USE_GITHUB as to why its being used (upstream does not (yet) distribute an sdist). Ask upstream to publish a source distribution. * COMMENT should match setup.py:description (modified to portlint compliance) where possible. * Makefile section ordering needs addressing (NO_ARCH, *_DEPENDS) * Add LICENSE_FILE * paramiko RUN_DEPENDS: FLAVOR needs to be PY_FLAVOUR * This package provides command line scripts. For packages that do this, package should be concurrent(installation)-safe. Use USE_PYTHON=concurrent, and QA that there are no files that share common locations between Python 2 and 3 build locations.
Closing with Feedback Timeout of > 1 month. Please reopen once the items in comment #2 have been addressed.
Created attachment 206633 [details] new port patch Here is a new patch with hopefully all issues resolved. I have changed the MAINTAINER to me because of the timeout with the original submitter, but am ok if someone else is the maintainer.
(In reply to John Hay from comment #4) Thanks! I do not want maintain this port, so new MAINTAINER is ok for me.
A commit references this bug: Author: kai Date: Mon Sep 9 14:58:49 UTC 2019 New revision: 511633 URL: https://svnweb.freebsd.org/changeset/ports/511633 Log: [NEW PORT]: security/py-exscript Exscript is a Python module and a template processor for automating network connections over protocols such as Telnet or SSH. We attempt to create the best possible set of tools for working with Telnet and SSH. WWW: https://github.com/knipknap/exscript PR: 233999 Submitted by: rozhuk.im@gmail.com (initial version), jhay Reviewed by: koobs Changes: head/security/Makefile head/security/py-exscript/ head/security/py-exscript/Makefile head/security/py-exscript/distinfo head/security/py-exscript/pkg-descr
(In reply to rozhuk.im from comment #0) (In reply to John Hay from comment #4) Committed, thank you both for the initial/revised patches and thank you John, for taking maintainership! I did only some minor fixes (sorting order of variables, executing ${REINPLACE_CMD} only once) and added a "do-test" target to make future QA easier.