Bug 234392 - devel/log4cxx: fix build with GCC-based architectures
Summary: devel/log4cxx: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-25 11:59 UTC by Piotr Kubaj
Modified: 2019-01-03 15:01 UTC (History)
1 user (show)

See Also:

Attachments
patch (443 bytes, patch)
2018-12-25 11:59 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (447 bytes, patch)
2019-01-02 13:01 UTC, Piotr Kubaj 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-12-25 11:59:05 UTC 
Created attachment 200493 [details]
patch

-Wno-c++11-narrowing is not supported by GCC. Set USE_CXXSTD=c++98 to build with both GCC and Clang.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-01-02 09:47:00 UTC 
For me this fails on amd64 with:

locationinfo.cpp:156:40: error: constant expression evaluates to 237 which cannot be narrowed to type 'char' [-Wc++11-narrowing]
         0x6E, 0x49, 0x6E, 0x66, 0x6F, 0xED, 0x99, 0xBB,
                                       ^~~~
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2019-01-02 13:01:08 UTC 
Created attachment 200709 [details]
v2

Sorry, the patch I sent here was wrong (it wouldn't build even on powerpc64).

I tested the right patch on amd64 but didn't sent it by mistake.

Here's the right patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-03 14:57:53 UTC 
A commit references this bug:

Author: linimon
Date: Thu Jan  3 14:57:25 UTC 2019
New revision: 489181
URL: https://svnweb.freebsd.org/changeset/ports/489181

Log:
  -Wno-c++11-narrowing is not supported by GCC.  Set USE_CXXSTD=c++98 to
  build with both GCC and Clang.

  PR:		234392
  Submitted by:	Piotr Kubaj

Changes:
  head/devel/log4cxx/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-03 15:01:59 UTC 
A commit references this bug:

Author: linimon
Date: Thu Jan  3 15:01:04 UTC 2019
New revision: 489182
URL: https://svnweb.freebsd.org/changeset/ports/489182

Log:
  MFH: r489181

  -Wno-c++11-narrowing is not supported by GCC.  Set USE_CXXSTD=c++98 to
  build with both GCC and Clang.

  PR:		234392
  Submitted by:	Piotr Kubaj

  Approved by:	portmgr (tier-2 blanket)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/devel/log4cxx/Makefile