An invalid errno check in netifaces sends netifaces.gateways() into an infinite loop. This renders iocage-1.0 unusable. Upstream issue: https://github.com/al45tair/netifaces/issues/28 Upstream PR: https://github.com/al45tair/netifaces/pull/29 Iocage issue: https://github.com/iocage/iocage/issues/766 Because this is a blocker for iocage, I suggest patching it in the ports tree, rather than waiting for a new release from upstream.
Created attachment 200694 [details] Fix invalid errno check in netifaces.gateways()
A commit references this bug: Author: bofh Date: Wed Jan 2 07:43:06 UTC 2019 New revision: 489059 URL: https://svnweb.freebsd.org/changeset/ports/489059 Log: net/py-netifaces: Update version 0.10.6=>0.10.7 - Fix invalid errno check in netifaces.gateways() [1] PR: 234558 [1] Submitted by: asomers [1] Changes: head/net/py-netifaces/Makefile head/net/py-netifaces/distinfo head/net/py-netifaces/files/ head/net/py-netifaces/files/patch-netifaces.c
Re-open for MFH (bugfix only version update)
(In reply to Kubilay Kocak from comment #3) Hi Koobs, As I have already committed do I need to notify ports-secteam@ or portmgr@ along with this bug or just a positive feedback notifies the team?
Technically only security updates require explicit approval (others are blanket approved), but it's nice to get approval as sometimes there are extra considerations with a stable branch that's further out of date then head. In this case the change doesn't bump the version, so netifaces dependents shouldn't have an issue, and this fixes a very single narrowly scoped code bug. Personally, I would merge: Approved by: ports-secteam (blanket, bugfix) But, if you'd like to wait or get explicit approval, you can request approval here with: Attachment -> Details -> maintainer-approval ? ports-secteam@...
A commit references this bug: Author: bofh Date: Thu Jan 3 11:32:52 UTC 2019 New revision: 489164 URL: https://svnweb.freebsd.org/changeset/ports/489164 Log: net/py-netifaces: Merge Quarterly - Port BUMP due to mistake in merge PR: 234558 Reported by: koobs Approved by: ports-secteam (blanket, bugfix) MFH: 2019Q1 Changes: head/net/py-netifaces/Makefile