Bug 234706 - MFC r342182 breaks loading /boot/kernel/radeonkms.ko on 12-STABLE
Summary: MFC r342182 breaks loading /boot/kernel/radeonkms.ko on 12-STABLE
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.0-STABLE
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Mark Johnston
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-01-07 20:48 UTC by Marek Zarychta
Modified: 2019-01-12 16:59 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2019-01-07 20:48:49 UTC 
After commit: r342689 in stable/12/sys module radeonkms.ko is broken:

info: [drm] Initialized drm 1.1.0 20060810                                      
link_elf_obj: symbol radeon_compat_ioctls undefined                             
linker_load_file: /boot/kernel/radeonkms.ko - unsupported file type          

As a workaround graphics/drm-legacy-kmod could be installed.
Comment 1 Mark Johnston freebsd_committer freebsd_triage 2019-01-07 21:25:15 UTC 
Sorry about that, looking now.  It should be possible to load the module if you compile with COMPAT_FREEBSD32.  Clearly I did not test that case properly.
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2019-01-07 21:25:28 UTC 
(In reply to Mark Johnston from comment #1)
Err, compile *without* COMPAT_FREEBSD32.
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2019-01-07 21:48:39 UTC 
https://reviews.freebsd.org/D18778
Comment 4 Marek Zarychta 2019-01-08 05:54:06 UTC 
(In reply to Mark Johnston from comment #3)
Patch proposed in D18778 resolves this issue. Thank you for the quick fix.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-01-09 17:24:07 UTC 
A commit references this bug:

Author: markj
Date: Wed Jan  9 17:23:09 UTC 2019
New revision: 342888
URL: https://svnweb.freebsd.org/changeset/base/342888

Log:
  Complete the removal of obsolete ioctl handlers.

  PR:		234706
  Reviewed by:	imp
  MFC after:	3 days
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D18778

Changes:
  head/sys/dev/drm2/radeon/radeon_drv.c
  head/sys/dev/drm2/radeon/radeon_drv.h
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-12 16:58:41 UTC 
A commit references this bug:

Author: markj
Date: Sat Jan 12 16:58:33 UTC 2019
New revision: 342969
URL: https://svnweb.freebsd.org/changeset/base/342969

Log:
  MFC r342888:
  Complete the removal of obsolete ioctl handlers.

  PR:	234706

Changes:
_U  stable/11/
  stable/11/sys/dev/drm2/radeon/radeon_drv.c
  stable/11/sys/dev/drm2/radeon/radeon_drv.h
_U  stable/12/
  stable/12/sys/dev/drm2/radeon/radeon_drv.c
  stable/12/sys/dev/drm2/radeon/radeon_drv.h