Created attachment 201192 [details] Fix the name of the tunables Shouldn't the tunables be? hw.vmm.l1d_flush -> hw.vmm.vmx.l1d_flush hw.vmm.l1d_flush_sw -> hw.vmm.vmx.l1d_flush_sw While here, clean up whitespace.
Reference: base r337785
A commit references this bug: Author: kib Date: Thu Jan 17 05:15:25 UTC 2019 New revision: 343108 URL: https://svnweb.freebsd.org/changeset/base/343108 Log: Trim whitespace at EoL, use tabs instead of spaces for indent. PR: 235004 Submitted by: Jose Luis Duran <jlduran@gmail.com> MFC after: 3 days Changes: head/sys/amd64/vmm/intel/vmx.c
(In reply to Jose Luis Duran from comment #0) When I answered the question on github, I mean that indeed it is more reasonable to put the tunables into hw.vmm.vmx leaf. But since they are already in hw.vmm, I think it would be unwise to rename them. The reason is that the rename breaks the ABI, worse, the breakage is silent. So anybody relying on the feature to protect against L1 terminal fault leaks, would suddently and silently appear unprotected. Meantime I committed the whitespace fixes, thank you.
(In reply to Konstantin Belousov from comment #3) Thank you. I see, I thought that setting `hw.vmm.vmx.l1d_flush` in loader.conf would enable/disable L1TF. Sorry for the misunderstanding.
A commit references this bug: Author: kib Date: Sun Jan 20 12:14:33 UTC 2019 New revision: 343211 URL: https://svnweb.freebsd.org/changeset/base/343211 Log: MFC r343108: Trim whitespace at EoL, use tabs instead of spaces for indent. PR: 235004 Changes: _U stable/12/ stable/12/sys/amd64/vmm/intel/vmx.c
A commit references this bug: Author: kib Date: Sun Jan 20 13:16:36 UTC 2019 New revision: 343212 URL: https://svnweb.freebsd.org/changeset/base/343212 Log: MFC r343108: Trim whitespace at EoL, use tabs instead of spaces for indent. PR: 235004 Changes: _U stable/11/ stable/11/sys/amd64/vmm/intel/vmx.c