Bug 235058 - [PATCH] japanese/man : fix build error on 12.0 Release
Summary: [PATCH] japanese/man : fix build error on 12.0 Release
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-19 08:18 UTC by Eijiro Shibusawa
Modified: 2019-01-24 18:09 UTC (History)
3 users (show)

See Also:
fernape: merge-quarterly+


Attachments
patch (1.58 KB, patch)
2019-01-19 08:18 UTC, Eijiro Shibusawa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eijiro Shibusawa 2019-01-19 08:18:40 UTC
Created attachment 201263 [details]
patch

The attached patch fixes "config.h is not found" build error on 12.0-Release (amd64).

NOTE:
- This port was tested with poudriere (11.2R / 12.0R amd64)
- The attached may fix same error on other platforms,
  however, it was NOT tested
  (the port is marked as broken on some platforms)
Comment 1 Ronald Klop 2019-01-22 15:46:22 UTC
The port compiles on aarch64 with this patch.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2019-01-22 18:44:07 UTC
(In reply to Ronald Klop from comment #1)

Thanks!

I'll wait a bit longer and see if we can get feedback for the other archs.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2019-01-23 16:38:15 UTC
ok on armv6 and armv7
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-23 22:05:04 UTC
A commit references this bug:

Author: fernape
Date: Wed Jan 23 22:04:20 UTC 2019
New revision: 491061
URL: https://svnweb.freebsd.org/changeset/ports/491061

Log:
  japanese/man: unbreak in several archs.

  The port was broken in 12 and in different archs.

  mips is still to be tested.

  PR: 235058
  Submitted by: phd_kimberlite@yahoo.co.jp
  Reviewed by:  Ronald Klop (aarch64)  mikael.urankar@gmail.com (armv6, armv7)
  MFH: 2019Q1 (build fix)

Changes:
  head/japanese/man/Makefile
  head/japanese/man/files/patch-man__Makefile
  head/japanese/man/files/patch-manpath__Makefile
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2019-01-23 22:08:22 UTC
Committed to HEAD.

Thanks a lot for the testing.

Awaiting confirmation to MFH to 2019Q1
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-24 18:08:39 UTC
A commit references this bug:

Author: fernape
Date: Thu Jan 24 18:08:18 UTC 2019
New revision: 491110
URL: https://svnweb.freebsd.org/changeset/ports/491110

Log:
  MFH: r491061

  japanese/man: unbreak in several archs.

  The port was broken in 12 and in different archs.

  mips is still to be tested.

  PR: 235058
  Submitted by: phd_kimberlite@yahoo.co.jp
  Reviewed by:  Ronald Klop (aarch64)  mikael.urankar@gmail.com (armv6, armv7)

  Approved by: ports-secteam (miwi)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/japanese/man/Makefile
  branches/2019Q1/japanese/man/files/patch-man__Makefile
  branches/2019Q1/japanese/man/files/patch-manpath__Makefile
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2019-01-24 18:09:59 UTC
Committed to quarter branch.

Thanks all of you!