Bug 235225 - swapinfo.8: Mention BLOCKSIZE in the ENVIRONMENT section
Summary: swapinfo.8: Mention BLOCKSIZE in the ENVIRONMENT section
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mateusz Piotrowski
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-01-27 00:59 UTC by Mateusz Piotrowski
Modified: 2023-10-04 11:24 UTC (History)
2 users (show)

See Also:


Attachments
pstat(8) (also known as swapinfo(8)) patch (765 bytes, patch)
2021-10-02 02:21 UTC, Felix Johnson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2019-01-27 00:59:47 UTC

    
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-01-18 13:45:33 UTC
We could probably copy the BLOCKSIZE description from df.1 or du.1.
Comment 2 Felix Johnson 2021-10-02 02:21:49 UTC
Created attachment 228343 [details]
pstat(8) (also known as swapinfo(8)) patch

Copy the ENVIRONMENT section from df(1) to swapinfo(8), except that the --si option is removed for swapinfo.
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-10-04 14:54:10 UTC
Comment on attachment 228343 [details]
pstat(8) (also known as swapinfo(8)) patch

Thanks for the patch!

>+If
>+.Ev BLOCKSIZE
>+is not set, and the
>+.Fl h , k ,
>+or
>+.Fl m
>+options are not specified, the block counts will be displayed in 512-byte
>+blocks.

I think that this part could be simplified to something along the lines of "defaults to 512-byte blocks".
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-08 19:36:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=39ad6e289f062fc8da239c0372f49b21f0911060

commit 39ad6e289f062fc8da239c0372f49b21f0911060
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2022-07-08 19:33:02 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2022-07-08 19:35:33 +0000

    swapinfo.8: Mention BLOCKSIZE in the ENVIRONMENT section

    Copy the ENVIRONMENT section from df(1) to swapinfo(8), except
    that the --si option is removed for swapinfo.

    PR:             235225
    Reported by:    0mp
    MFC after:      3 days

 usr.sbin/pstat/pstat.8 | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2022-07-08 19:37:24 UTC
Thanks for the patch, Felix!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-04 11:24:31 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=873117aefd2a3b796cc82942a885f066b1d6bf5d

commit 873117aefd2a3b796cc82942a885f066b1d6bf5d
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2022-07-08 19:33:02 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2023-10-04 11:14:57 +0000

    swapinfo.8: Mention BLOCKSIZE in the ENVIRONMENT section

    Copy the ENVIRONMENT section from df(1) to swapinfo(8), except
    that the --si option is removed for swapinfo.

    PR:             235225
    Reported by:    0mp
    MFC after:      3 days

    (cherry picked from commit 39ad6e289f062fc8da239c0372f49b21f0911060)

 usr.sbin/pstat/pstat.8 | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)