Bug 235655 - audio/fmit: Fix options passed to the build; Add license tags; Group USExx lines
Summary: audio/fmit: Fix options passed to the build; Add license tags; Group USExx lines
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-10 21:55 UTC by Yuri Victorovich
Modified: 2019-02-24 12:40 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danilo)

Attachments
patch (1.69 KB, patch)
2019-02-10 21:55 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2019-02-10 21:55:31 UTC 
Created attachment 201908 [details]
patch

This is qmake-based project, options can't be passed using CMAKE tags.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2019-02-10 21:56:41 UTC 
Danilo,

Please also consider removing the ALSA option, it isn't functional.

Yuri
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-02-24 12:39:42 UTC 
A commit references this bug:

Author: danilo
Date: Sun Feb 24 12:39:25 UTC 2019
New revision: 493756
URL: https://svnweb.freebsd.org/changeset/ports/493756

Log:
  - Fix options helpers. Should be QMAKE after the migration from cmake to qmake
  - Fix LICENSE
  While here
  - Use buildtools_build instead of buildtools

  PR:		235655
  Submitted by:	yuri

Changes:
  head/audio/fmit/Makefile
Comment 3 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2019-02-24 12:40:59 UTC 
Committed. Thank you!