Bug 235798 - [PATCH][asmc] Add support for for macmini2,1 to asmc kernel module
Summary: [PATCH][asmc] Add support for for macmini2,1 to asmc kernel module
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.2-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: David Bright
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-02-17 08:51 UTC by Trev
Modified: 2019-03-07 15:32 UTC (History)
2 users (show)

See Also:
dab: mfc-stable12+
dab: mfc-stable11+
dab: mfc-stable10-

Attachments
Adds support for macmini2,1 hardware to asmc kernel module (984 bytes, patch)
2019-02-17 08:51 UTC, Trev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trev 2019-02-17 08:51:36 UTC 
Created attachment 202085 [details]
Adds support for macmini2,1 hardware to asmc kernel module

The Apple System Management Controller (asmc) kernel module lacks details for the macmini2,1 hardware version.

Fix: See attached patches for asmc.c and asmcvar.h which have been running successfully on my FreeBSD 11.2-STABLE system.

How-To-Repeat: kldload supplied asmc.ko

Patch against FreeBSD 11.2-STABLE r344225 attached.

----------------------------------------------------
Output from the patched asmc:

dev.asmc.0.temp.northbridge_proximity2: 54
dev.asmc.0.temp.northbridge_proximity1: 54
dev.asmc.0.temp.cpu_proximity2: 66
dev.asmc.0.temp.cpu_proximity1: 64
dev.asmc.0.temp.cpu_heatsink: 65
dev.asmc.0.temp.cpu_die: 83
dev.asmc.0.temp.ambient_air: 51
dev.asmc.0.fan.0.targetspeed: 3374
dev.asmc.0.fan.0.maxspeed: 5500
dev.asmc.0.fan.0.minspeed: 2000
dev.asmc.0.fan.0.safespeed: 0
dev.asmc.0.fan.0.speed: 3371
dev.asmc.0.fan.0.id: Master 
dev.asmc.0.%parent: acpi0
dev.asmc.0.%pnpinfo: _HID=APP0001 _UID=0
dev.asmc.0.%location: handle=\_SB_.PCI0.LPCB.SMC_
dev.asmc.0.%driver: asmc
dev.asmc.0.%desc: Apple SMC Mac Mini 2,1
----------------------------------------------------
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-25 21:59:43 UTC 
A commit references this bug:

Author: dab
Date: Mon Feb 25 21:59:02 UTC 2019
New revision: 344553
URL: https://svnweb.freebsd.org/changeset/base/344553

Log:
  asmc: Add support for Mac mini 2,1

  PR:		235798
  Submitted by:	Trev <fbsdbugs4@sentry.org>
  Reported by:	Trev <fbsdbugs4@sentry.org>
  MFC after:	1 week

Changes:
  head/sys/dev/asmc/asmc.c
  head/sys/dev/asmc/asmcvar.h
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-07 15:31:04 UTC 
A commit references this bug:

Author: dab
Date: Thu Mar  7 15:30:49 UTC 2019
New revision: 344888
URL: https://svnweb.freebsd.org/changeset/base/344888

Log:
  MFC r344553:

  asmc: Add support for Mac mini 2,1

  PR:		235798
  Submitted by:	Trev <fbsdbugs4@sentry.org>
  Reported by:	Trev <fbsdbugs4@sentry.org>

Changes:
_U  stable/12/
  stable/12/sys/dev/asmc/asmc.c
  stable/12/sys/dev/asmc/asmcvar.h
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-03-07 15:32:07 UTC 
A commit references this bug:

Author: dab
Date: Thu Mar  7 15:31:32 UTC 2019
New revision: 344889
URL: https://svnweb.freebsd.org/changeset/base/344889

Log:
  MFC r344553:

  asmc: Add support for Mac mini 2,1

  PR:             235798
  Submitted by:   Trev <fbsdbugs4@sentry.org>
  Reported by:    Trev <fbsdbugs4@sentry.org>

Changes:
_U  stable/11/
  stable/11/sys/dev/asmc/asmc.c
  stable/11/sys/dev/asmc/asmcvar.h