Bug 235864 - net/ndproxy: Update to 3.2 (Fixes API changes to pfil hooks in CURRENT)
Summary: net/ndproxy: Update to 3.2 (Fixes API changes to pfil hooks in CURRENT)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Luca Pizzamiglio
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-02-19 17:42 UTC by Alexandre Fenyo
Modified: 2019-04-06 13:36 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly?

Attachments
net/ndproxy port contents (6.00 KB, text/plain)
2019-02-19 17:42 UTC, Alexandre Fenyo 		no flags Details
poudriere log file (19.99 KB, text/plain)
2019-02-19 17:44 UTC, Alexandre Fenyo 		no flags Details
poudriere log file (19.67 KB, text/plain)
2019-02-19 17:44 UTC, Alexandre Fenyo 		no flags Details
poudriere log file (19.98 KB, text/plain)
2019-02-19 17:45 UTC, Alexandre Fenyo 		no flags Details
poudriere log file (20.28 KB, text/plain)
2019-02-19 17:45 UTC, Alexandre Fenyo 		no flags Details
svn patch (svn diff) for the new version of ndproxy (4.29 KB, patch)
2019-03-25 13:28 UTC, Alexandre Fenyo 		fbsd.bugzilla: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Fenyo 2019-02-19 17:42:44 UTC 
Created attachment 202163 [details]
net/ndproxy port contents

Hi,

pkg-fallout has reported recently that the port net/ndproxy could not compile anymore. I've investigated and found that it was due to changes in the pfil(9) hooks API.

Therefore, I've updated the port to support both the previous and the new versions of the pfil(9) API.

I've checked it with poudriere on 13.0-CURRENT (1300012) for amd64 and i386, and on 12.0-RELEASE (1200086) for amd64 and i386.
It compiles correctly without any warning nor error.

You will find this new version in the attachement.
Please, can you update the ports tree with this new version of ndproxy?

Sincerely,
Alexandre Fenyo
Comment 1 Alexandre Fenyo 2019-02-19 17:44:32 UTC 
Created attachment 202164 [details]
poudriere log file
Comment 2 Alexandre Fenyo 2019-02-19 17:44:58 UTC 
Created attachment 202165 [details]
poudriere log file
Comment 3 Alexandre Fenyo 2019-02-19 17:45:19 UTC 
Created attachment 202166 [details]
poudriere log file
Comment 4 Alexandre Fenyo 2019-02-19 17:45:40 UTC 
Created attachment 202167 [details]
poudriere log file
Comment 5 Alexandre Fenyo 2019-03-25 06:59:29 UTC 
Hi,

I continue to receive regularly the alert from pkg-fallout.
Is it possible for somebody to update the port with the new version in attachement?

Many thanks for your work!
Sincerely,
Alexandre Fenyo
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-03-25 09:26:12 UTC 
Alexandre, can you please:

- Provide the fix/update in the form of a unified diff (like `svn patch`) against the head version of the port.
- Set the maintainer-approval flag to + on attachments, for ports you maintain, to signify maintainer approval. Attachment -> Details -> maintainer-approval [+]
Comment 7 Alexandre Fenyo 2019-03-25 13:28:51 UTC 
Created attachment 203128 [details]
svn patch (svn diff) for the new version of ndproxy

Here is the svn patch for the updated version of this port.

Apply the patch this way (suppose the patch file is /tmp/ndproxy.patch):
% cd /usr/ports/net
% svn patch /tmp/ndproxy.patch


Note:
the patch has been generated the following way:
% cd /usr/ports/net
% svn diff ndproxy > /tmp/ndproxy.patch

This is a patch between the new version of ndproxy and the current HEAD of the ports tree in the svn repository.
Comment 8 Alexandre Fenyo 2019-03-25 13:30:54 UTC 
Thanks for the tips, I've just added a svn patch (built with svn diff) and tagged it "maintainer approved".

Sincerely,
Alexandre Fenyo
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-04-06 13:31:16 UTC 
A commit references this bug:

Author: pizzamig
Date: Sat Apr  6 13:30:31 UTC 2019
New revision: 498095
URL: https://svnweb.freebsd.org/changeset/ports/498095

Log:
  net/ndproxy: Update to 3.2

  This release contains fixes for API changes to pfil hooks in CURRENT

  PR:		235864
  Submitted by:	maintainer

Changes:
  head/net/ndproxy/Makefile
  head/net/ndproxy/distinfo
  head/net/ndproxy/files/ndproxy.in
Comment 10 Luca Pizzamiglio freebsd_committer freebsd_triage 2019-04-06 13:36:14 UTC 
Committed! Thanks!