Bug 236207 - devel/mdb: fails to build with clang 8
Summary: devel/mdb: fails to build with clang 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Baldwin
URL: https://reviews.freebsd.org/D19602
Keywords: needs-patch
Depends on:
Blocks: 236062
  Show dependency treegraph
 
Reported: 2019-03-04 12:50 UTC by Jan Beich
Modified: 2019-04-19 18:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jhb)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-03-04 12:50:36 UTC
$ poudriere jail -cj clang8 -v projects/clang800-import -m svn+https
$ poudriere testport -j clang8 devel/mdb
[...]
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:45:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                TDS_INACTIVE = 0x0,
                ^
/usr/include/sys/proc.h:330:3: note: previous declaration is here
                TDS_INACTIVE = 0x0,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:45:3: error: redefinition of enumerator 'TDS_INACTIVE'
                TDS_INACTIVE = 0x0,
                ^
/usr/include/sys/proc.h:330:3: note: previous definition is here
                TDS_INACTIVE = 0x0,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:46:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                TDS_INHIBITED,
                ^
/usr/include/sys/proc.h:331:3: note: previous declaration is here
                TDS_INHIBITED,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:46:3: error: redefinition of enumerator 'TDS_INHIBITED'
                TDS_INHIBITED,
                ^
/usr/include/sys/proc.h:331:3: note: previous definition is here
                TDS_INHIBITED,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:47:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                TDS_CAN_RUN,
                ^
/usr/include/sys/proc.h:332:3: note: previous declaration is here
                TDS_CAN_RUN,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:47:3: error: redefinition of enumerator 'TDS_CAN_RUN'
                TDS_CAN_RUN,
                ^
/usr/include/sys/proc.h:332:3: note: previous definition is here
                TDS_CAN_RUN,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:48:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                TDS_RUNQ,
                ^
/usr/include/sys/proc.h:333:3: note: previous declaration is here
                TDS_RUNQ,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:48:3: error: redefinition of enumerator 'TDS_RUNQ'
                TDS_RUNQ,
                ^
/usr/include/sys/proc.h:333:3: note: previous definition is here
                TDS_RUNQ,
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:49:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                TDS_RUNNING
                ^
/usr/include/sys/proc.h:334:3: note: previous declaration is here
                TDS_RUNNING
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:49:3: error: redefinition of enumerator 'TDS_RUNNING'
                TDS_RUNNING
                ^
/usr/include/sys/proc.h:334:3: note: previous definition is here
                TDS_RUNNING
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:63:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                PRS_NEW = 0,
                ^
/usr/include/sys/proc.h:577:3: note: previous declaration is here
                PRS_NEW = 0,            /* In creation */
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:63:3: error: redefinition of enumerator 'PRS_NEW'
                PRS_NEW = 0,
                ^
/usr/include/sys/proc.h:577:3: note: previous definition is here
                PRS_NEW = 0,            /* In creation */
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:64:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                PRS_NORMAL,
                ^
/usr/include/sys/proc.h:578:3: note: previous declaration is here
                PRS_NORMAL,             /* threads can be run. */
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:64:3: error: redefinition of enumerator 'PRS_NORMAL'
                PRS_NORMAL,
                ^
/usr/include/sys/proc.h:578:3: note: previous definition is here
                PRS_NORMAL,             /* threads can be run. */
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:65:3: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
                PRS_ZOMBIE
                ^
/usr/include/sys/proc.h:579:3: note: previous declaration is here
                PRS_ZOMBIE
                ^
In file included from findstack_subr.c:35:
modules/kernel/kernel.h:65:3: error: redefinition of enumerator 'PRS_ZOMBIE'
                PRS_ZOMBIE
                ^
/usr/include/sys/proc.h:579:3: note: previous definition is here
                PRS_ZOMBIE
                ^
findstack_subr.c:219:8: error: case value not in enumerated type 'enum (anonymous enum at modules/kernel/kernel.h:44:2)' [-Werror,-Wswitch]
                case TDS_INACTIVE:
                     ^
findstack_subr.c:221:8: error: case value not in enumerated type 'enum (anonymous enum at modules/kernel/kernel.h:44:2)' [-Werror,-Wswitch]
                case TDS_INHIBITED:
                     ^
findstack_subr.c:217:8: error: case value not in enumerated type 'enum (anonymous enum at modules/kernel/kernel.h:44:2)' [-Werror,-Wswitch]
                case TDS_CAN_RUN:
                     ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]

http://package18.nyi.freebsd.org/data/headamd64PR236062-default/2019-03-01_06h42m53s/logs/errors/mdb-0.3_1.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-03-04 23:31:09 UTC
Reminder: Clang 8 was merged to 13.0-CURRENT in base r344779. Maintainers, expect pkg-fallout@ mail soon.
Comment 2 John Baldwin freebsd_committer freebsd_triage 2019-03-26 16:26:58 UTC
Patch waiting for a reviewer.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-05 19:08:23 UTC
A commit references this bug:

Author: jhb
Date: Fri Apr  5 19:08:15 UTC 2019
New revision: 497977
URL: https://svnweb.freebsd.org/changeset/ports/497977

Log:
  Fix build with clang 8.

  Workaround clang 8 compile issues on head.  Note that this requires
  changes to the kernel source tree in r345196.

  While here, switch to using a date for the version number since there
  are no real version numbers in the git repository.  This doesn't use
  the 'g' prefix since the older versions that already exist would sort
  after it.

  PR:	236207
  Reviewed by:	swills, jrm
  Differential Revision:	https://reviews.freebsd.org/D19602

Changes:
  head/devel/mdb/Makefile
  head/devel/mdb/distinfo
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-04-19 18:59:28 UTC
A commit references this bug:

Author: swills
Date: Fri Apr 19 18:58:38 UTC 2019
New revision: 499384
URL: https://svnweb.freebsd.org/changeset/ports/499384

Log:
  MFH: r497977

  Fix build with clang 8.

  Workaround clang 8 compile issues on head.  Note that this requires
  changes to the kernel source tree in r345196.

  While here, switch to using a date for the version number since there
  are no real version numbers in the git repository.  This doesn't use
  the 'g' prefix since the older versions that already exist would sort
  after it.

  PR:	236207
  Reviewed by:	swills, jrm
  Differential Revision:	https://reviews.freebsd.org/D19602

  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/devel/mdb/Makefile
  branches/2019Q2/devel/mdb/distinfo