Bug 236224 - lang/harbour mark broken with openssl111 and on 12.x
Summary: lang/harbour mark broken with openssl111 and on 12.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-04 18:45 UTC by m.tsatsenko
Modified: 2019-03-14 08:05 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback? (m.tsatsenko)

Attachments
the patch (2.95 KB, text/plain)
2019-03-04 18:45 UTC, m.tsatsenko 		m.tsatsenko: maintainer-approval+
Details
patch to fix options (910 bytes, patch)
2019-03-13 21:32 UTC, m.tsatsenko 		m.tsatsenko: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description m.tsatsenko 2019-03-04 18:45:14 UTC 
Created attachment 202555 [details]
the patch

- Mark BROKEN with openssl111 and FreeBSD 12.x
- Fix plist
- Bump PORTREVISION
- Add LICENSE 
- Update WWW, clean up Makefile

QA:
poudriere 112amd64 - OK
portlint - no errors. There are a few warnings I wasn't able to get rid of. Any advice is much appreciated.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-05 01:34:21 UTC 
A commit references this bug:

Author: swills
Date: Tue Mar  5 01:33:42 UTC 2019
New revision: 494667
URL: https://svnweb.freebsd.org/changeset/ports/494667

Log:
  lang/harbour: mark broken with openssl111 and on 12.x

  While here, clean up a bit

  PR:		236224
  Submitted by:	m.tsatsenko@gmail.com (maintainer)

Changes:
  head/lang/harbour/Makefile
  head/lang/harbour/pkg-descr
  head/lang/harbour/pkg-plist
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-03-05 01:40:07 UTC 
Committed, thanks!
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-05 06:37:33 UTC 
After this commit all options are broken.  The port now sets
options helper after bsd.port.pre.mk now, so they are never
processed and are ineffective.

To resolve this the bsd.port.pre.mk and .if/BROKEN block should
be moved to just before post-patch.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-13 12:43:38 UTC 
Ping? This is still broken.
Comment 5 m.tsatsenko 2019-03-13 21:32:02 UTC 
Created attachment 202847 [details]
patch to fix options

The patch attached should fix the problem.
Not sure whether PORTREVISION bump is needed here

portlint no errors
112amd64 OK
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-03-14 08:04:48 UTC 
A commit references this bug:

Author: tobik
Date: Thu Mar 14 08:04:42 UTC 2019
New revision: 495690
URL: https://svnweb.freebsd.org/changeset/ports/495690

Log:
  lang/harbour: Restore options after r494667

  PR:		236224

Changes:
  head/lang/harbour/Makefile
  head/lang/harbour/pkg-plist
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-14 08:05:11 UTC 
(In reply to m.tsatsenko from comment #5)
> Created attachment 202847 [details]
> patch to fix options
> 
> The patch attached should fix the problem.

Thank you.