Bug 236300 - Flakey test case: lib.libarchive.functional_test.test_fuzz_zip
Summary: Flakey test case: lib.libarchive.functional_test.test_fuzz_zip
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-05 22:17 UTC by Li-Wen Hsu
Modified: 2019-04-10 21:47 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2019-03-05 22:17:12 UTC 
This case usually fails because of timeout, for example:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/10384/testReport/junit/lib.libarchive/functional_test/test_fuzz_zip/
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2019-03-06 23:25:00 UTC 
Hi Martin, do you think it has something todo with this fix? https://github.com/libarchive/libarchive/pull/1153
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2019-03-06 23:30:16 UTC 
This case also failed few times in upstream:

https://cirrus-ci.com/task/5912586726932480
https://cirrus-ci.com/task/4744429291175936

(before merging pull request #153)
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2019-03-25 05:01:46 UTC 
The command `cd /usr/tests/lib/libarchive && kyua test functional_test:test_fuzz_zip` fails every 5~6 times.

After applying the patch in github pr 1153, it has been continuous running for ~12 hours without failing.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-03-25 11:50:40 UTC 
A commit references this bug:

Author: mm
Date: Mon Mar 25 11:50:00 UTC 2019
New revision: 345497
URL: https://svnweb.freebsd.org/changeset/base/345497

Log:
  MFV r345495:
  Sync libarchive with vendor.

  Relevant vendor changes:
    PR #1153: fixed 2 bugs in ZIP reader [1]
    PR #1143: ensure archive_read_disk_entry_from_file() uses ARCHIVE_READ_DISK
    Changes to file flags code, support more file flags on FreeBSD:
      UF_OFFLINE, UF_READONLY, UF_SPARSE, UF_REPARSE, UF_SYSTEM
      UF_ARCHIVE is not supported by intention (yet)

  PR:		236300
  MFC after:	2 weeks

Changes:
_U  head/contrib/libarchive/
  head/contrib/libarchive/libarchive/archive_blake2sp_ref.c
  head/contrib/libarchive/libarchive/archive_entry.c
  head/contrib/libarchive/libarchive/archive_read_disk_entry_from_file.c
  head/contrib/libarchive/libarchive/archive_read_support_format_rar5.c
  head/contrib/libarchive/libarchive/archive_read_support_format_zip.c
  head/contrib/libarchive/libarchive/archive_string.c
  head/contrib/libarchive/libarchive/archive_write_disk_posix.c
  head/contrib/libarchive/libarchive/archive_write_set_format_7zip.c
  head/contrib/libarchive/libarchive/test/test_entry.c
  head/contrib/libarchive/libarchive/test/test_read_format_rar5.c
  head/contrib/libarchive/libarchive/test/test_read_format_xar.c
  head/contrib/libarchive/libarchive/test/test_read_format_zip.c
  head/contrib/libarchive/libarchive/test/test_read_format_zip_bz2_hang.zip.uu
  head/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_1.zipx.uu
  head/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_2.zipx.uu
  head/lib/libarchive/tests/Makefile
Comment 5 Ed Maste freebsd_committer freebsd_triage 2019-03-28 14:08:08 UTC 
Is this fixed now?
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2019-03-28 14:12:14 UTC 
No more failures observed in the past three days after r345497.
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-04-10 21:46:03 UTC 
A commit references this bug:

Author: mm
Date: Wed Apr 10 21:45:26 UTC 2019
New revision: 346103
URL: https://svnweb.freebsd.org/changeset/base/346103

Log:
  MFC r345497:
  Sync libarchive with vendor.

  Relevant vendor changes:
    PR #1153: fixed 2 bugs in ZIP reader [1]
    PR #1143: ensure archive_read_disk_entry_from_file() uses ARCHIVE_READ_DISK
    Changes to file flags code, support more file flags on FreeBSD:
      UF_OFFLINE, UF_READONLY, UF_SPARSE, UF_REPARSE, UF_SYSTEM
      UF_ARCHIVE is not supported by intention (yet)

  PR:		236300 [1]

Changes:
_U  stable/12/
  stable/12/contrib/libarchive/libarchive/archive_blake2sp_ref.c
  stable/12/contrib/libarchive/libarchive/archive_entry.c
  stable/12/contrib/libarchive/libarchive/archive_read_disk_entry_from_file.c
  stable/12/contrib/libarchive/libarchive/archive_read_support_format_rar5.c
  stable/12/contrib/libarchive/libarchive/archive_read_support_format_zip.c
  stable/12/contrib/libarchive/libarchive/archive_string.c
  stable/12/contrib/libarchive/libarchive/archive_write_disk_posix.c
  stable/12/contrib/libarchive/libarchive/archive_write_set_format_7zip.c
  stable/12/contrib/libarchive/libarchive/test/test_entry.c
  stable/12/contrib/libarchive/libarchive/test/test_read_format_rar5.c
  stable/12/contrib/libarchive/libarchive/test/test_read_format_xar.c
  stable/12/contrib/libarchive/libarchive/test/test_read_format_zip.c
  stable/12/contrib/libarchive/libarchive/test/test_read_format_zip_bz2_hang.zip.uu
  stable/12/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_1.zipx.uu
  stable/12/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_2.zipx.uu
  stable/12/lib/libarchive/tests/Makefile
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-04-10 21:47:06 UTC 
A commit references this bug:

Author: mm
Date: Wed Apr 10 21:46:09 UTC 2019
New revision: 346104
URL: https://svnweb.freebsd.org/changeset/base/346104

Log:
  MFC r345497:
  Sync libarchive with vendor.

  Relevant vendor changes:
    PR #1153: fixed 2 bugs in ZIP reader [1]
    PR #1143: ensure archive_read_disk_entry_from_file() uses ARCHIVE_READ_DISK
    Changes to file flags code, support more file flags on FreeBSD:
      UF_OFFLINE, UF_READONLY, UF_SPARSE, UF_REPARSE, UF_SYSTEM
      UF_ARCHIVE is not supported by intention (yet)

  PR:		236300 [1]

Changes:
_U  stable/11/
  stable/11/contrib/libarchive/libarchive/archive_blake2sp_ref.c
  stable/11/contrib/libarchive/libarchive/archive_entry.c
  stable/11/contrib/libarchive/libarchive/archive_read_disk_entry_from_file.c
  stable/11/contrib/libarchive/libarchive/archive_read_support_format_rar5.c
  stable/11/contrib/libarchive/libarchive/archive_read_support_format_zip.c
  stable/11/contrib/libarchive/libarchive/archive_string.c
  stable/11/contrib/libarchive/libarchive/archive_write_disk_posix.c
  stable/11/contrib/libarchive/libarchive/archive_write_set_format_7zip.c
  stable/11/contrib/libarchive/libarchive/test/test_entry.c
  stable/11/contrib/libarchive/libarchive/test/test_read_format_rar5.c
  stable/11/contrib/libarchive/libarchive/test/test_read_format_xar.c
  stable/11/contrib/libarchive/libarchive/test/test_read_format_zip.c
  stable/11/contrib/libarchive/libarchive/test/test_read_format_zip_bz2_hang.zip.uu
  stable/11/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_1.zipx.uu
  stable/11/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_2.zipx.uu
  stable/11/lib/libarchive/tests/Makefile
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-04-10 21:47:08 UTC 
A commit references this bug:

Author: mm
Date: Wed Apr 10 21:46:30 UTC 2019
New revision: 346105
URL: https://svnweb.freebsd.org/changeset/base/346105

Log:
  MFC r345497:
  Sync libarchive with vendor.

  Relevant vendor changes:
    PR #1153: fixed 2 bugs in ZIP reader [1]
    PR #1143: ensure archive_read_disk_entry_from_file() uses ARCHIVE_READ_DISK
    Changes to file flags code, support more file flags on FreeBSD:
      UF_OFFLINE, UF_READONLY, UF_SPARSE, UF_REPARSE, UF_SYSTEM
      UF_ARCHIVE is not supported by intention (yet)

  PR:		236300 [1]

Changes:
_U  stable/10/
  stable/10/contrib/libarchive/libarchive/archive_blake2sp_ref.c
  stable/10/contrib/libarchive/libarchive/archive_entry.c
  stable/10/contrib/libarchive/libarchive/archive_read_disk_entry_from_file.c
  stable/10/contrib/libarchive/libarchive/archive_read_support_format_rar5.c
  stable/10/contrib/libarchive/libarchive/archive_read_support_format_zip.c
  stable/10/contrib/libarchive/libarchive/archive_string.c
  stable/10/contrib/libarchive/libarchive/archive_write_disk_posix.c
  stable/10/contrib/libarchive/libarchive/archive_write_set_format_7zip.c
  stable/10/contrib/libarchive/libarchive/test/test_entry.c
  stable/10/contrib/libarchive/libarchive/test/test_read_format_rar5.c
  stable/10/contrib/libarchive/libarchive/test/test_read_format_xar.c
  stable/10/contrib/libarchive/libarchive/test/test_read_format_zip.c
  stable/10/contrib/libarchive/libarchive/test/test_read_format_zip_bz2_hang.zip.uu
  stable/10/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_1.zipx.uu
  stable/10/contrib/libarchive/libarchive/test/test_read_format_zip_ppmd8_crash_2.zipx.uu
  stable/10/lib/libarchive/tests/Makefile