Bug 236307 - Mk/Uses/qt.mk: restore conditional dependency on sql-ibase
Summary: Mk/Uses/qt.mk: restore conditional dependency on sql-ibase
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-06 02:35 UTC by Mark Linimon
Modified: 2019-03-10 10:06 UTC (History)
4 users (show)

See Also:

Attachments
patch to Mk/Uses/qt.mk (766 bytes, patch)
2019-03-06 02:35 UTC, Mark Linimon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2019-03-06 02:35:17 UTC 
Created attachment 202639 [details]
patch to Mk/Uses/qt.mk

During the transition from Mk/bsd.qt.mk to Mk/Uses/qt.mk in r473503, a previous change to the former was omitted; in particular, r463394:

  "Disable Qt4 sql-ibase plugin on not-(i386|amd64)

   ibase is Firebird, which only builds on i386 and amd64. This patch
   squashes the ibase plugin for Qt4."

Since sql-ibase (firebird25) is only for x86, this omission once again regressed qt on non-x86 architectures.

This patch restores the regressed behavior.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2019-03-06 18:38:11 UTC 
Moin moin

Looks good to me. Go ahead.


mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-10 10:02:44 UTC 
A commit references this bug:

Author: adridg
Date: Sun Mar 10 10:02:38 UTC 2019
New revision: 495245
URL: https://svnweb.freebsd.org/changeset/ports/495245

Log:
  During the transition from Mk/bsd.qt.mk to Mk/Uses/qt.mk in r473503, a previous change to the former was omitted; in particular, r463394:

    "Disable Qt4 sql-ibase plugin on not-(i386|amd64)

     ibase is Firebird, which only builds on i386 and amd64. This patch
     squashes the ibase plugin for Qt4."

  Re-apply lost change (databases/qt5-sqldrivers-ibase is x86-only).

  PR:		236307
  Submitted by:	linimon

Changes:
  head/Mk/Uses/qt.mk