Bug 236697 - www/shellinabox - build against SSL from ports, fix connection problem with TLS 1.3
Summary: www/shellinabox - build against SSL from ports, fix connection problem with T...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-21 09:24 UTC by Pietro Cerutti
Modified: 2019-03-21 15:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (olivier)


Attachments
Build shellinabox with SSL from ports (606 bytes, text/plain)
2019-03-21 09:24 UTC, Pietro Cerutti
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti freebsd_committer freebsd_triage 2019-03-21 09:24:56 UTC
Created attachment 203028 [details]
Build shellinabox with SSL from ports

By default, shellinabox is configured not to be linked against an SSL implementation. Instead, it dlopen's libcrypto.so at runtime:

https://github.com/shellinabox/shellinabox/blob/4f0ecc31ac6f985e0dd3f5a52cbfc0e9251f6361/libhttp/ssl.c#L206-L222

This means that - unless LD_LIBRARY_PATH is set - shellinabox always picks up openssl from base. This is the cause of this issue:
https://github.com/shellinabox/shellinabox/issues/453

The patch attached turns off runtime loading and set CFLAGS and LDFLAGS so that openssl from base is picked up (if it's there).

The PAM code doesn't build without runtime loading, so I just turned it off. I can try to find the time to look into it as well, if needed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-21 15:05:43 UTC
A commit references this bug:

Author: olivier
Date: Thu Mar 21 15:05:14 UTC 2019
New revision: 496469
URL: https://svnweb.freebsd.org/changeset/ports/496469

Log:
  Fix: build against SSL from ports and connection problem with TLS 1.3

  PR:		236697
  Submitted by:	gahr

Changes:
  head/www/shellinabox/Makefile
Comment 2 Olivier Cochard freebsd_committer freebsd_triage 2019-03-21 15:06:36 UTC
Thanks for the troubleshooting and patch!