Created attachment 203032 [details] patch FreeBSD/powerpc* need to include machine/pio.h and sys/types.h in src/iodrv/io-unix-access.c to build this port. Additionally, sort USES and add USES=gl gnome sdl. Tested on powerpc64 and amd64. Hardware sponsored by IntegriCloud.
rejected, please do not sort USES alphabetically.
It looks wrong to add USES=SDL for GTK3GUI. It looks wrong to add USES=gnome for SDLGUI.
A commit references this bug: Author: dinoex Date: Mon Mar 25 08:43:38 UTC 2019 New revision: 496803 URL: https://svnweb.freebsd.org/changeset/ports/496803 Log: - add USES localbase:ldflags PR: 236704 Changes: head/emulators/vice/Makefile
(In reply to Dirk Meyer from comment #1) > please do not sort USES alphabetically. Why? This is the recommendation of portlint. AFAIK there is no reason not to follow it; if there is, we need to find out what code in bsd.*.mk is preventing it, and fix both that and portlint.
In some cases the order of the USES is important, as some USES depend on macros defined by on other USES. This is not fixable in the current framework. Please fix portlint. The suggested patch brings regressions and unneeded dependencies. global USES is wrong, as the usage depends on the option selected.
Created attachment 203316 [details] patch It looks like I forgot to svn add this patch. Can you commit it? It fixes compilation with GCC.
Opening.
A commit references this bug: Author: dinoex Date: Fri May 10 15:30:12 UTC 2019 New revision: 501180 URL: https://svnweb.freebsd.org/changeset/ports/501180 Log: - fix build with GCC-based architectures PR: 236704 Submitted by: Piotr Kubaj Changes: head/emulators/vice/Makefile head/emulators/vice/files/patch-src_iodrv_io-unix-access.c