Created attachment 203035 [details] gcalcli 4.0.4 port files gcalcli 4.0 release removes most / all of the issues with legacy Google interfaces.
Hi, thank you for the patch. It builds fine so far and I have only two questions: - I assume that the DOCS option was removed because the supplied documentation isn't really useful (sparse README.md and some screenshots)? - The patch file also introduces the PYTHON_PKGNAMEPREFIX variable that will yield to different packages for each Python flavor -> py27-gcalcli, py36-gcalcli, etc. If this is intended then there's some more work to do. I have a suggestion for the second point: As deskutils/gcalcli seems to be an application it makes sense to keep the current package name. This can be achieved by adding the keyword "noflavors" to USE_PYTHON. This leads to another small question: Should deskutils/gcalcli use the default Python version (current: 2.7) or do you want switch to Python 3?
In regards to DOCS. Honestly, no idea how that works or what it was doing. Porters Handbook doesn't have any info that I can find and Mk/bsd. files don't seem to have anything relevant either that I can see. I don't know how it picks what to install and where it goes. I haven't tried it on python 2.7, but upstream lists it as working. I agree that not having a prefix in the package name would be the prettier way to do it, but I thought the prefix was required for some reason. My system / poudriere default is python 3.6, but I guess as far as a global default for pkg builds go I'm not sure what the push for ports, in general, to do is.
(In reply to Henrik Hudson from comment #2) Thank you for the info. I've opened a pre-commit review some days ago and once it gets approval from one of my mentors, the update is ready to land: https://reviews.freebsd.org/D19984
A commit references this bug: Author: kai Date: Sun May 12 14:39:30 UTC 2019 New revision: 501382 URL: https://svnweb.freebsd.org/changeset/ports/501382 Log: deskutils/gcalcli: Update to 4.0.4 * Remove options FUZZYDATE, SIMPLEJSON and DOCS: * devel/py-parsedatetime is now explicitly required * devel/py-simplejson is no longer used since the 3.2 release * The supplied documentation doesn't contain useful information * Simplify the Makefile by using Python's distutils to build the port * Flavorize the port because the port also works with Python 3 While I'm here: * Add location to the license file Changelog since 3.4.0: * Minor bugfixes: conky colors, issues with setup.py * Major code refactor: modularity, testing, PEP8 compliance * Bugfixes for issues reported during alpha phase * Multiday events support * Fix textwrap for widechar at cut index * Fix errors attempting to import events * No weekend option * Fixed bug with add and iterators * Deal with more encoding issues... * Get error from JSON object * Support for Python3 via six * Move from gflags to argparse (This is a major, non-backwards compatible change (hence the roll up to v4)) https://github.com/insanum/gcalcli/blob/v4.0.4/ChangeLog PR: 236707 Submitted by: Henrik Hudson <ports@thelanman.net> (maintainer) Reviewed by: tcberner Differential Revision: https://reviews.freebsd.org/D19984 Changes: head/deskutils/gcalcli/Makefile head/deskutils/gcalcli/distinfo
Committed, thank you for the patch and sorry for the delay!