Bug 236924 - [maintainer update] update deskutils/spice-gtk to 0.36
Summary: [maintainer update] update deskutils/spice-gtk to 0.36
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks: 236893
  Show dependency tree / graph
 
Reported: 2019-04-01 03:37 UTC by Jack
Modified: 2019-04-13 16:43 UTC (History)
3 users (show)

See Also:

Attachments
Patch to upgrade to 0.36 (5.16 KB, text/plain)
2019-04-01 03:37 UTC, Jack 		no flags Details
Added lib_depends on devel/json-glib (5.48 KB, patch)
2019-04-03 01:29 UTC, Jack 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2019-04-01 03:37:04 UTC 
Created attachment 203280 [details]
Patch to upgrade to 0.36
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2019-04-02 04:24:02 UTC 
Testbuild failed:

checking for JSON... no
configure: error: Package requirements (json-glib-1.0) were not met:

Package 'json-glib-1.0', required by 'virtual:world', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables JSON_CFLAGS
and JSON_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
===>  Script "configure" failed unexpectedly.
Please report the problem to xxjack12xx@gmail.com [maintainer] and attach the
"/wrkdirs/usr/ports/deskutils/spice-gtk/work/spice-gtk-0.36/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/deskutils/spice-gtk
build of deskutils/spice-gtk | spice-gtk-0.36 ended at Tue Apr  2 13:22:16 JST 2019
build time: 00:01:19
!!! build failure encountered !!!
[00:23:33] Error: Build failed in phase: configure
Comment 2 Jack 2019-04-03 01:29:21 UTC 
Created attachment 203335 [details]
Added lib_depends on devel/json-glib
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2019-04-03 03:40:56 UTC 
Committed with minor plist changes, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-04-03 03:41:12 UTC 
A commit references this bug:

Author: meta
Date: Wed Apr  3 03:40:36 UTC 2019
New revision: 497615
URL: https://svnweb.freebsd.org/changeset/ports/497615

Log:
  deskutils/spice-gtk: Update to 0.36

  PR:		236924
  Submitted by:	Jack <xxjack12xx@gmail.com> (maintainer)
  Relnotes:	https://github.com/freedesktop/spice-gtk/blob/master/NEWS

Changes:
  head/deskutils/spice-gtk/Makefile
  head/deskutils/spice-gtk/distinfo
  head/deskutils/spice-gtk/pkg-plist
Comment 5 Oleg Ginzburg 2019-04-07 19:35:19 UTC 
from relnotes https://github.com/freedesktop/spice-gtk/blob/master/NEWS:

---
 Require spice-protocol >= 1.12.15 ( (I think there's a typo here, should be: 0.12.15)
---

I think we should fix this string

BUILD_DEPENDS=  spice-protocol>=0.12.14:devel/spice-protocol \
RUN_DEPENDS=    spice-protocol>=0.12.14:devel/spice-protocol

to:

BUILD_DEPENDS=  spice-protocol>=0.12.15:devel/spice-protocol \
RUN_DEPENDS=    spice-protocol>=0.12.15:devel/spice-protocol

Thx!
Comment 6 Jack 2019-04-08 05:21:50 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237091

The relnotes are upstream, they probably made a typo. I'll email them