Bug 236925 - graphics/ogre3d: Update to 1.11.5
Summary: graphics/ogre3d: Update to 1.11.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Oliver Lehmann
URL:
Keywords: needs-qa
Depends on: 239487
Blocks:
  Show dependency treegraph
 
Reported: 2019-04-01 06:13 UTC by Hiroo Ono
Modified: 2019-08-10 23:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (oliver)


Attachments
update patch to ogre-1.11.5 (61.73 KB, text/plain)
2019-04-01 06:18 UTC, Hiroo Ono
no flags Details
patch to ogre-1.11.5 update (807.00 KB, patch)
2019-04-09 08:15 UTC, Hiroo Ono
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2019-04-01 06:13:53 UTC
This patch updates graphics/ogre3d to version 1.11.5.
It is needed for opencv-contrib/modules/ovis. I am working on graphics/opencv -> graphics/opencv3 update to 3.4.5, and it will appear there.

Build tests of every option on and off are done on amd64 and i386.
Run test on amd64 is yet to be done.

This update breaks:
* graphics/rigsofrods-pagedgeometry:
  Changes conforming to ogre 1.11.5 are in github repository, but not released.
* x11-toolkits/mygui-ogre:
  changes conforming to ogre 1.11.5 are in github repository, but not released.
  I will attach a port patch later.
* graphics/cegui:
  changes conforming to ogre 1.11.5 are in bitbucket repository, but not released.
* misc/visp:
  I do not know if there is any update. The version in ports is quite new.
  Dependency to ogre3d is an option default off, anyway.
* games/opendumgeons:
  Dependent port graphics/cegui fails.
* games/stuntrally:
  Version 2.6.1 has just been tagged on github. I did not try it yet.
Comment 1 Hiroo Ono 2019-04-01 06:18:34 UTC
Created attachment 203282 [details]
update patch to ogre-1.11.5
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-04-01 06:40:07 UTC
Comment on attachment 203282 [details]
update patch to ogre-1.11.5

@Hiroo Could you include the patch as a plain text attachment produced via `svn diff` against the port directory please.
Comment 3 Hiroo Ono 2019-04-01 07:58:45 UTC
Uncompressed patch is about 1100kB that exceed the size limit. Mainly, plist addition of doxygen output.
I placed the patch here:
https://barleycorn.oikumene.net/ports-patch/ogre3d-1.11.5.diff
Should I file it to reviews.freebsd.org?
Comment 4 Hiroo Ono 2019-04-09 08:15:08 UTC
Created attachment 203526 [details]
patch to ogre-1.11.5 update

- I managed to omit *.tex files from doxygen output.
- added -DNDEBUG to CXXFLAGS.
- verified that SampleBroswer run on amd64 (need GLX)

Among the ports dependent on ogre3d, games/stuntrally seems to work with patches: https://github.com/stuntrally/stuntrally/pull/17/files
I will work on this, after opencv updates are settled.
Comment 5 Oliver Lehmann freebsd_committer freebsd_triage 2019-04-19 11:41:33 UTC
I have the update ready locally. 
I'm not sure yet what to do with all the ports which will break and what to do with aarch64 and powerpc (no possibility to test)

games/stuntrally - amdmi3@FreeBSD.org
games/opendungeons - ports@FreeBSD.org
games/py-fife/Makefile - fiziologus@gmail.com (because of cegui)
graphics/rigsofrods-pagedgeometry - monwarez@mailoo.org
graphics/rigsofrods-caelum - monwarez@mailoo.org
graphics/cegui - myself
misc/visp/Makefile - yuri@FreeBSD.org
x11-toolkits/mygui-ogre/Makefile - amdmi3@FreeBSD.org
Comment 6 Hiroo Ono 2019-04-19 14:04:43 UTC
(In reply to Oliver Lehmann from comment #5)
mygui-ogre has updated code (not released) in their github repository and I filed an update to the port: bug #236926
For stuntrally, I have a patch for the port borrowed from this pull request https://github.com/stuntrally/stuntrally/pull/17/files . It compiles (with both  ogre 1.9.x and ogre 1.11.x) but dies at a point I could not debug. If someone is eager to debug, I will send the patch.

The person who sent the pull request above says that he or she also worked on opendungeons, but I did not take a look yet.

For the cegui, some commit messages in their repository mention of ogre 1.11.x, but there is no release. As it seems unable to get a tarball corresponding to a commit hash from BitBucket, maybe I should ask them to release first.

For the other ports, I have no news from the first message.
I need Ogre 1.10.x or newer for graphics/opencv update to 3.4.5, but it is related to extra module in opencv_contrib and I made it an option. So, I can wait for these ports to adapt to Ogre 1.11.x.
Comment 7 Oliver Lehmann freebsd_committer freebsd_triage 2019-04-19 14:17:53 UTC
I tried the current version of the hg branch of cegui 0-8 which shows ogre 1.11 support - but it does not compile.

Either I move ogre3d 1.9 to a seperate port and update ogre3d to 1.11 or I just update ogre3d to 1.11 and will mark all dependant ports as BROKEN.

I'm not sure right now which way I'll go.
Comment 8 Oliver Lehmann freebsd_committer freebsd_triage 2019-04-21 09:30:47 UTC
Maintainers of the depending ports informed that I'll commit the update on the 4th or 5th of May and willing to commit any patch they might supply to get their ports working with 1.11.5. I'll mark the remaining ports BROKEN.
Comment 9 Hiroo Ono 2019-04-23 20:29:52 UTC
Just FYI.

https://barleycorn.oikumene.net/ports-patch/stuntrally-ver2.diff
This patch (WIP) to games/stuntrally port along with mygui-ogre update (bug #236926) makes it compile and run. But no meshes are applied.
I am not able to solve the issue.
Comment 10 commit-hook freebsd_committer freebsd_triage 2019-07-27 23:56:26 UTC
A commit references this bug:

Author: oliver
Date: Sat Jul 27 23:56:03 UTC 2019
New revision: 507479
URL: https://svnweb.freebsd.org/changeset/ports/507479

Log:
  update Ogre3D to 1.11.5

  PR:		236925
  Submitted by:	Hiroo Ono

Changes:
  head/graphics/ogre3d/Makefile
  head/graphics/ogre3d/distinfo
  head/graphics/ogre3d/files/patch-CMakeLists.txt
  head/graphics/ogre3d/files/patch-CMake_ConfigureBuild.cmake
  head/graphics/ogre3d/files/patch-Ogre.i
  head/graphics/ogre3d/files/patch-OgreBitwise.h
  head/graphics/ogre3d/files/patch-OgreMain_include_OgrePlatformInformation.h
  head/graphics/ogre3d/files/patch-Tools_XMLConverter_CMakeLists.txt
  head/graphics/ogre3d/pkg-plist
Comment 11 Oliver Lehmann freebsd_committer freebsd_triage 2019-08-10 23:36:17 UTC
finally committed un July 27