Bug 237264 - deskutils/spice-gtk, add USES=gnome, add missing multimedia/libva LIB_DEPENDS
Summary: deskutils/spice-gtk, add USES=gnome, add missing multimedia/libva LIB_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-13 16:45 UTC by Matthias Andree
Modified: 2019-04-14 08:23 UTC (History)
2 users (show)

See Also:
xxjack12xx: maintainer-feedback+

Attachments
add LIB_DEPENDS+=libva-x11.so:multimedia/libva and USES+=gnome (828 bytes, patch)
2019-04-13 16:45 UTC, Matthias Andree 		mandree: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2019-04-13 16:45:45 UTC 
Created attachment 203646 [details]
add LIB_DEPENDS+=libva-x11.so:multimedia/libva and USES+=gnome

There is a consistency warning that USE_GNOME should not longer be used without USES=gnome, so we add that (per the patch).

Also, the port will happily pick up libva if found, but there is no option to turn it off. Add libva-.x11.so:multimedia/libva to LIB_DEPENDS.
Comment 1 Jack 2019-04-14 03:40:29 UTC 
Looks ok
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2019-04-14 08:23:25 UTC 
Thanks, committed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-14 08:23:34 UTC 
A commit references this bug:

Author: mandree
Date: Sun Apr 14 08:22:48 UTC 2019
New revision: 498873
URL: https://svnweb.freebsd.org/changeset/ports/498873

Log:
  deskutils/spice-gtk: add missing LIB_DEPENDS, USES+=gnome

  spice-gtk picks up libva when present with no option to disable it easily,
  so make it a requisite for a consistent dependency situation in bare-metal
  and jail builds.

  The FreeBSD ports rig complains that USE_GNOME requires USES=gnome,
  so add that.

  PR:		237264
  Approved by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/deskutils/spice-gtk/Makefile