Bug 237378 - gpio GPIOACCESS32 bug.
Summary: gpio GPIOACCESS32 bug.
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ian Lepore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-19 04:54 UTC by HIROKI MORI
Modified: 2019-04-30 00:59 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description HIROKI MORI 2019-04-19 04:54:52 UTC 
I think GPIO_PIN_ACCESS_32 4th argument is a32->change_pins.

https://svnweb.freebsd.org/base/head/sys/dev/gpio/gpioc.c?view=markup#l195
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-25 22:28:23 UTC 
A commit references this bug:

Author: ian
Date: Thu Apr 25 22:27:56 UTC 2019
New revision: 346713
URL: https://svnweb.freebsd.org/changeset/base/346713

Log:
  Fix typo: the 4th argument to GPIO_PIN_ACCESS_32 is the set of pins to
  change, not the variable used to return the original pin state.

  PR:		237378
  Reported by:	Mori Hiroki <yamori813@yahoo.co.jp>

Changes:
  head/sys/dev/gpio/gpioc.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-30 00:59:14 UTC 
A commit references this bug:

Author: ian
Date: Tue Apr 30 00:58:43 UTC 2019
New revision: 346938
URL: https://svnweb.freebsd.org/changeset/base/346938

Log:
  MFC r346713:

  Fix typo: the 4th argument to GPIO_PIN_ACCESS_32 is the set of pins to
  change, not the variable used to return the original pin state.

  PR:		237378
  Reported by:	Mori Hiroki <yamori813@yahoo.co.jp>

Changes:
_U  stable/12/
  stable/12/sys/dev/gpio/gpioc.c