Bug 237432 - devel/libffcall: Remove BROKEN on aarch64
Summary: devel/libffcall: Remove BROKEN on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-04-21 11:25 UTC by Val Packett
Modified: 2019-04-23 16:38 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ndowens04)
koobs: merge-quarterly?


Attachments
libffcall.patch (758 bytes, patch)
2019-04-21 11:25 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2019-04-21 11:25:05 UTC
Created attachment 203858 [details]
libffcall.patch

Built fine on current, lang/clisp works.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-04-21 11:29:47 UTC
@Greg 

Was this tested with a native machine, cross-built or something?
With poudriere or just a build/install? 
What about runtime?

We may also want confirmation it builds on other supported FreeBSD versions too
Comment 2 Val Packett 2019-04-21 12:03:03 UTC
(In reply to Kubilay Kocak from comment #1)

Fully native, just make installed on a packet c2.large.arm (Ampere eMAG).

Just tested FFI specifically in CLISP (which presumably uses this FFI library for… well, FFI):

(use-package "FFI")
(def-call-out gethostname1 (:name "gethostname")
  (:arguments (name (c-ptr (c-array-max character 256)) :out :alloca) (len int))
  (:return-type int) (:language :stdc) (:library :default))
(gethostname1 256)

does work fine.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2019-04-23 16:27:26 UTC
Committed, thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-04-23 16:29:21 UTC
A commit references this bug:

Author: linimon
Date: Tue Apr 23 16:28:43 UTC 2019
New revision: 499767
URL: https://svnweb.freebsd.org/changeset/ports/499767

Log:
  Now builds on aarch64.

  PR:		237432
  Submitted by:	Greg V <greg at unrelenting dot technology>
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/devel/libffcall/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-04-23 16:38:30 UTC
A commit references this bug:

Author: linimon
Date: Tue Apr 23 16:38:14 UTC 2019
New revision: 499768
URL: https://svnweb.freebsd.org/changeset/ports/499768

Log:
  MFH: r499767

  Now builds on aarch64.

  PR:		237432
  Submitted by:	Greg V <greg at unrelenting dot technology>
  Approved by:	portmgr (tier-2 blanket)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/devel/libffcall/Makefile