Bug 237507 - lang/rust: fix build on powerpc64
Summary: lang/rust: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Rust Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-23 19:48 UTC by Piotr Kubaj
Modified: 2019-05-19 08:23 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (rust)


Attachments
patch (15.68 KB, patch)
2019-04-23 19:48 UTC, Piotr Kubaj
tobik: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-23 19:48:59 UTC
Created attachment 203943 [details]
patch

Since I couldn't manage to test rust DR in time, it was committed untested on powerpc64, and as it turned out, it's broken.

I'm attaching a patch to fix build, but since my amd64 workstation is down for now, I couldn't test it on amd64. Could you review it?

Upstream seems to have changed CPU features detection, so that needed some fixes.

auxvec.rs was copied from Linux's auxvec.rs and it seems to work.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-23 19:58:44 UTC
Comment on attachment 203943 [details]
patch

See https://reviews.freebsd.org/D19940 instead.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-26 04:29:03 UTC
A commit references this bug:

Author: tobik
Date: Fri Apr 26 04:28:48 UTC 2019
New revision: 500077
URL: https://svnweb.freebsd.org/changeset/ports/500077

Log:
  lang/rust: Update to 1.34.1

  - Add stdsimd patches from D19940 to attempt to unbreak powerpc64, armv{6,7} [1]

  Changes:	https://blog.rust-lang.org/2019/04/25/Rust-1.34.1.html
  PR:		237507 [1]
  Submitted by:	mikael.urankar@gmail.com [1]
  Reviewed by:	jbeich [1]
  Tested by:	pkubaj (stdsimd patches with 1.34.0 on powerpc64) [1]
  With hat:	rust
  Differential Revision:	https://reviews.freebsd.org/D19940 [1]

Changes:
  head/lang/rust/Makefile
  head/lang/rust/distinfo
  head/lang/rust/files/patch-src_stdsimd_crates_std__detect_src_detect_os_freebsd_arm.rs
  head/lang/rust/files/patch-src_stdsimd_crates_std__detect_src_detect_os_freebsd_auxvec.rs
  head/lang/rust/files/patch-src_stdsimd_crates_std__detect_src_detect_os_freebsd_mod.rs
  head/lang/rust/files/patch-src_stdsimd_crates_std__detect_src_detect_os_freebsd_powerpc.rs
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-26 04:30:22 UTC
Added the patches from D19940. Let's hope this is fine.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-07 14:00:14 UTC
(In reply to Tobias Kortkamp from comment #3)
> Added the patches from D19940. Let's hope this is fine.

Does not look like it and it seems to hang during the build now:
http://pylon.nyi.freebsd.org/data/head-powerpc64-default/p500451_s346935/logs/errors/rust-1.34.1.log
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2019-05-07 14:49:29 UTC
(In reply to Tobias Kortkamp from comment #4)
It builds fine on my powerpc.
Comment 6 Piotr Kubaj freebsd_committer freebsd_triage 2019-05-07 16:02:44 UTC
(In reply to Tobias Kortkamp from comment #4)
Also builds here:
https://talos.anongoth.pl/data/powerpc64-default/2019-05-05_01h04m26s/logs/rust-1.34.1.log

pylon has the default timeout settings so many ports timeout. Someone who has root access to pylon should fix it.
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-18 09:17:16 UTC
It built fine this time.  Did someone change any builder settings or were we
just lucky this time?

http://pylon.nyi.freebsd.org/data/head-powerpc64-default/p501607_s347555/logs/rust-1.34.1.log

(In reply to mikael.urankar from comment #7)
> https://github.com/rust-lang-nursery/stdsimd/commit/
> 0102817f9e7c8476b4c2b0d5d399f6d33e6ec83a

Thank you.