Bug 237867 - audio/libopenshot-audio: fix build with GCC-based architectures
Summary: audio/libopenshot-audio: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-13 07:33 UTC by Piotr Kubaj
Modified: 2019-05-29 07:42 UTC (History)
2 users (show)

See Also:
tatsuki_makino: maintainer-feedback+

Attachments
patch (2.46 KB, patch)
2019-05-13 07:33 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (tatsuki_makino)
 Details | Diff
patch for audio/libopenshot-audio (10.83 KB, patch)
2019-05-15 07:31 UTC, Tatsuki Makino 		tatsuki_makino: maintainer-approval+
Details | Diff
poudriere log (90.36 KB, text/plain)
2019-05-15 07:35 UTC, Tatsuki Makino 		tatsuki_makino: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-05-13 07:33:51 UTC 
Created attachment 204347 [details]
patch

Add USES=compiler:c++11-lang because of:
CMake Error in CMakeLists.txt:
  Target "openshot-audio" requires the language dialect "CXX11" , but CMake
  does not know the compile flags to use to enable it.

Also include cstring in JuceLibraryCode/modules/juce_core/containers/juce_ArrayBase.h and JuceLibraryCode/modules/juce_core/memory/juce_Memory.h
Comment 1 Tatsuki Makino 2019-05-15 07:31:27 UTC 
Created attachment 204384 [details]
patch for audio/libopenshot-audio

(In reply to Piotr Kubaj from comment #0)

Thank you for the report. And I'm sorry that it's in an imperfect condition.

#include <cstring> exists in ${WRKSRC}/JuceLibraryCode/modules/juce_core/system/juce_StandardHeader.h. My patch prevents the preprocessor from deleting it.
I also fixed the other branch points for each OS.
Comment 2 Tatsuki Makino 2019-05-15 07:35:13 UTC 
Created attachment 204386 [details]
poudriere log

This is a log with attachment 204384 [details] and USE_GCC=yes.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2019-05-29 04:01:43 UTC 
Mentor approves.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-05-29 07:42:46 UTC 
A commit references this bug:

Author: pkubaj
Date: Wed May 29 07:42:29 UTC 2019
New revision: 502935
URL: https://svnweb.freebsd.org/changeset/ports/502935

Log:
  audio/libopenshot-audio: fix build with GCC-based architectures

  error:
  CMake Error in CMakeLists.txt:
    Target "openshot-audio" requires the language dialect "CXX11" , but CMake
    does not know the compile flags to use to enable it.

  PR:		237867
  Submitted by:	tatsuki_makino@hotmail.com (maintainer)
  Approved by:	linimon (mentor)

Changes:
  head/audio/libopenshot-audio/Makefile
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_files_juce__File.cpp
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_juce__core.h
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_native_juce__BasicNativeHeaders.h
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_native_juce__linux__Files.cpp
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_native_juce__posix__SharedCode.h
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_system_juce__PlatformDefs.h
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_system_juce__StandardHeader.h
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_text_juce__CharPointer__ASCII.h
  head/audio/libopenshot-audio/files/patch-JuceLibraryCode_modules_juce__core_threads_juce__Process.h