Bug 238515 - sysutils/minipro: fix build with GCC-based architectures
Summary: sysutils/minipro: fix build with GCC-based architectures
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-12 07:42 UTC by Piotr Kubaj
Modified: 2019-07-09 09:50 UTC (History)
1 user (show)

See Also:

Attachments
patch (578 bytes, patch)
2019-06-12 07:42 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-06-12 07:42:12 UTC 
Created attachment 205002 [details]
patch

This port needs new GCC to build on GCC architectures.

Actually respect CC by not replacing it with clang, instead remove it to use CC passed from ports.

Also respect CFLAGS.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2019-06-12 07:42:12 UTC 
Maintainer informed via mail
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-07-06 20:08:14 UTC 
This built for me on powerpc64 20190627.  As mentor, I approve it for commit via maintainer-timeout.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2019-07-06 20:10:43 UTC 
(In reply to Mark Linimon from comment #2)

Well, actually, I tested the earlier version of the patch, but the timeout still applies.  Close in favor of D20819.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-07-09 09:50:00 UTC 
A commit references this bug:

Author: pkubaj
Date: Tue Jul  9 09:49:19 UTC 2019
New revision: 506276
URL: https://svnweb.freebsd.org/changeset/ports/506276

Log:
  sysutils/minipro: fix build with GCC-based architectures

  This port needs new GCC to build on GCC architectures.

  Actually respect CC by putting ?= instead of =.

  Also respect CFLAGS and remove post-patch step, instead use a separate patch file.

  PR: 238515
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20819

Changes:
  head/sysutils/minipro/Makefile
  head/sysutils/minipro/files/
  head/sysutils/minipro/files/patch-Makefile