Bug 238653 - qlxgbe: Fix pointer printing in ql_ioctl.c
Summary: qlxgbe: Fix pointer printing in ql_ioctl.c
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Kevin Bowling
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-06-17 11:18 UTC by Fuqian
Modified: 2024-09-29 04:03 UTC (History)
1 user (show)

See Also:


Attachments
The patch file (1.04 KB, patch)
2019-06-17 11:18 UTC, Fuqian
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fuqian 2019-06-17 11:18:38 UTC
Created attachment 205171 [details]
The patch file

In ql_slowpath_log, the address of log->buffer will be printed out.
To avoid kernel address leakage.
Remove this kernel address printing in ql_slowpath_log.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-28 05:21:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a58b4ee025fcac480e44e1f56acffe2feacc5845

commit a58b4ee025fcac480e44e1f56acffe2feacc5845
Author:     Fuqian <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:18:52 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-28 05:18:52 +0000

    qlxgbe: Remove pointer printing in ql_ioctl.c
    PR:             238653
    MFC after:      1 week

 sys/dev/qlxgbe/ql_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-07 05:50:19 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=88462a368a7fefeae4b9f5a190254d2e54950a2f

commit 88462a368a7fefeae4b9f5a190254d2e54950a2f
Author:     Fuqian <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:18:52 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-06-07 05:47:02 +0000

    qlxgbe: Remove pointer printing in ql_ioctl.c

    PR:             238653
    MFC after:      1 week

    (cherry picked from commit a58b4ee025fcac480e44e1f56acffe2feacc5845)

 sys/dev/qlxgbe/ql_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-29 04:03:01 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=06c854adc98472b9e51cb064446d9f664edba5f4

commit 06c854adc98472b9e51cb064446d9f664edba5f4
Author:     Fuqian <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:18:52 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-09-29 03:58:54 +0000

    qlxgbe: Remove pointer printing in ql_ioctl.c

    PR:             238653

    (cherry picked from commit a58b4ee025fcac480e44e1f56acffe2feacc5845)

 sys/dev/qlxgbe/ql_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)