Bug 238782 - [exp-run] Upgrade Qt to 5.13.0
Summary: [exp-run] Upgrade Qt to 5.13.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL: https://github.com/freebsd/freebsd-po...
Keywords:
: qt5-5.12.3 (view as bug list)
Depends on:
Blocks: pyqt-5.13.0
  Show dependency treegraph
 
Reported: 2019-06-23 19:58 UTC by Tobias C. Berner
Modified: 2019-10-01 04:36 UTC (History)
2 users (show)

See Also:
antoine: exp-run+


Attachments
v1 (203.50 KB, patch)
2019-06-23 19:58 UTC, Tobias C. Berner
no flags Details | Diff
v2 (208.34 KB, patch)
2019-07-06 15:14 UTC, Tobias C. Berner
no flags Details | Diff
v3 (292.96 KB, patch)
2019-09-01 21:12 UTC, Tobias C. Berner
no flags Details | Diff
v4 (292.09 KB, patch)
2019-09-13 11:39 UTC, Tobias C. Berner
no flags Details | Diff
v5 (293.04 KB, patch)
2019-09-29 14:46 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer freebsd_triage 2019-06-23 19:58:00 UTC
Created attachment 205302 [details]
v1

Hi there

kde@ would like to ask for an exp-run to upgrade Qt5 to 5.13.0.

The patch can be found here:
https://people.freebsd.org/~tcberner/patches/qt5-5.13.0.v1.diff

mfg Tobias
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2019-06-23 19:59:45 UTC
*** Bug 237344 has been marked as a duplicate of this bug. ***
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2019-06-24 05:15:15 UTC
Please hold on with the exp-run, there is some issue with the generated cmake files which makes dependent ports fail.
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2019-07-06 15:14:15 UTC
Created attachment 205545 [details]
v2

Here's the fixed patch:
https://people.freebsd.org/~tcberner/patches/qt5-5.13.0.v2.diff

In the git-tree it looked fine (apart from x11-toolkits/qt5-gtkplatform).

mfg Tobias
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2019-07-09 05:32:29 UTC
New failures on 12.0 amd64:

+ {"origin"=>"cad/librecad", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"deskutils/calibre", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"deskutils/znotes", "phase"=>"configure", "errortype"=>"WRKDIR"}
+ {"origin"=>"devel/qtcreator", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"games/multimc", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"games/pentobi", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"graphics/diffpdf", "phase"=>"configure", "errortype"=>"WRKDIR"}
+ {"origin"=>"graphics/dspdfviewer", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"graphics/gpxsee", "phase"=>"build", "errortype"=>"WRKDIR"}
+ {"origin"=>"graphics/qgis", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"graphics/qgis-ltr", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"graphics/radiance", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"lang/basic256", "phase"=>"build", "errortype"=>"linker_error"}
+ {"origin"=>"misc/zygrib", "phase"=>"build", "errortype"=>"linker_error"}
+ {"origin"=>"multimedia/shotcut", "phase"=>"build", "errortype"=>"WRKDIR"}
+ {"origin"=>"net-im/nheko", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"net-im/qTox", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"net-p2p/torrent-file-editor", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"net/rclone-browser", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"print/qpdfview", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"science/massxpert", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"sysutils/qtpass", "phase"=>"build", "errortype"=>"makefile"}
+ {"origin"=>"sysutils/twmn", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"sysutils/unetbootin", "phase"=>"configure", "errortype"=>"WRKDIR"}
+ {"origin"=>"x11-toolkits/qt5-gtkplatform", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"x11-toolkits/qwt5-qt5", "phase"=>"build", "errortype"=>"clang"}
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2019-07-09 05:34:22 UTC
New failure logs on 12.0 amd64:


http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/librecad-2.2.0.r1_8.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/calibre-3.44.0_2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/znotes-0.4.5.20150825_3.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qtcreator-4.9.2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/multimc-0.6.5.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/pentobi-15.0_1.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/diffpdf-2.1.3_8.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/dspdfviewer-1.15.1_16.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/gpxsee-7.9.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qgis-3.6.2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qgis-ltr-3.4.7.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/radiance-video-0.6.0_4.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/basic256-1.1.4.0_2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/zygrib-8.0.1_3.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/shotcut-19.06.15.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/nheko-0.6.4_1.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qTox-1.16.3.529_3.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/torrent-file-editor-0.3.14.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/rclone-browser-1.2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qpdfview-0.4.18.b1_3.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/massxpert-3.6.1.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qtpass-1.2.3_2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/twmn-g20171216_6.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/unetbootin-661.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qt5-gtkplatform-0.2.2_2.log
http://package18.nyi.freebsd.org/data/120amd64-default-PR238728/2019-07-08_13h18m22s/logs/errors/qwt5-qt5-5.2.3_2.log
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2019-07-09 05:36:19 UTC
New failures on 12.0 i386:

 {"origin"=>"cad/librecad", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"deskutils/calibre", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"deskutils/znotes", "phase"=>"configure", "errortype"=>"WRKDIR"}
+ {"origin"=>"devel/qtcreator", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"emulators/virtualbox-ose", "phase"=>"build", "errortype"=>"???"}
+ {"origin"=>"games/multimc", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"games/pentobi", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"graphics/diffpdf", "phase"=>"configure", "errortype"=>"WRKDIR"}
+ {"origin"=>"graphics/dspdfviewer", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"graphics/gpxsee", "phase"=>"build", "errortype"=>"WRKDIR"}
+ {"origin"=>"graphics/qgis", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"graphics/qgis-ltr", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"graphics/radiance", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"lang/basic256", "phase"=>"build", "errortype"=>"linker_error"}
+ {"origin"=>"multimedia/shotcut", "phase"=>"build", "errortype"=>"WRKDIR"}
+ {"origin"=>"net-im/nheko", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"net-im/qTox", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"net-p2p/torrent-file-editor", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"net/rclone-browser", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"print/qpdfview", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"science/massxpert", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"sysutils/qtpass", "phase"=>"build", "errortype"=>"makefile"}
+ {"origin"=>"sysutils/twmn", "phase"=>"build", "errortype"=>"clang_werror"}
+ {"origin"=>"sysutils/unetbootin", "phase"=>"configure", "errortype"=>"WRKDIR"}
+ {"origin"=>"x11-toolkits/qt5-gtkplatform", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"x11-toolkits/qwt5-qt5", "phase"=>"build", "errortype"=>"clang"}
Comment 7 Antoine Brodin freebsd_committer freebsd_triage 2019-07-09 05:38:13 UTC
New failure logs on 12.0 i386:

http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/librecad-2.2.0.r1_8.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/calibre-3.44.0_2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/znotes-0.4.5.20150825_3.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qtcreator-4.9.2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/virtualbox-ose-5.2.30.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/multimc-0.6.5.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/pentobi-15.0_1.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/diffpdf-2.1.3_8.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/dspdfviewer-1.15.1_16.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/gpxsee-7.9.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qgis-3.6.2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qgis-ltr-3.4.7.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/radiance-video-0.6.0_4.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/basic256-1.1.4.0_2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/shotcut-19.06.15.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/nheko-0.6.4_1.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qTox-1.16.3.529_3.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/torrent-file-editor-0.3.14.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/rclone-browser-1.2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qpdfview-0.4.18.b1_3.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/massxpert-3.6.1.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qtpass-1.2.3_2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/twmn-g20171216_6.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/unetbootin-661.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qt5-gtkplatform-0.2.2_2.log
http://pb2.nyi.freebsd.org/data/120i386-default-PR238728/2019-07-08_13h18m08s/logs/errors/qwt5-qt5-5.2.3_2.log
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-07-11 04:23:32 UTC
A commit references this bug:

Author: tcberner
Date: Thu Jul 11 04:22:27 UTC 2019
New revision: 506397
URL: https://svnweb.freebsd.org/changeset/ports/506397

Log:
  graphics/qgis-ltr: prepare for Qt 5.13

  PR:		238782

Changes:
  head/graphics/qgis-ltr/files/patch-src_analysis_interpolation_qgsinterpolator.h
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-07-11 04:30:39 UTC
A commit references this bug:

Author: tcberner
Date: Thu Jul 11 04:30:28 UTC 2019
New revision: 506398
URL: https://svnweb.freebsd.org/changeset/ports/506398

Log:
  deskutils/calibre: prepare for Qt 5.13

  PR:		238782

Changes:
  head/deskutils/calibre/files/patch-git_0a5dc0
Comment 10 commit-hook freebsd_committer freebsd_triage 2019-07-13 08:42:07 UTC
A commit references this bug:

Author: makc
Date: Sat Jul 13 08:42:01 UTC 2019
New revision: 506520
URL: https://svnweb.freebsd.org/changeset/ports/506520

Log:
  x11-toolkits/qwt5-qt5:
  - Add patch to fix build with upcoming Qt 5.13

  PR:	238782

Changes:
  head/x11-toolkits/qwt5-qt5/files/patch-src_qwt__clipper.cpp
Comment 11 commit-hook freebsd_committer freebsd_triage 2019-07-13 10:04:19 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 10:04:00 UTC 2019
New revision: 506535
URL: https://svnweb.freebsd.org/changeset/ports/506535

Log:
  x11-toolkits/qt5-gtkplatform: prepare for Qt 5.13

  PR:		238782

Changes:
  head/x11-toolkits/qt5-gtkplatform/files/patch-src_qgtkintegration.cpp
Comment 12 commit-hook freebsd_committer freebsd_triage 2019-07-13 11:20:20 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 11:20:01 UTC 2019
New revision: 506538
URL: https://svnweb.freebsd.org/changeset/ports/506538

Log:
  sysutils/twmn: prepare for Qt 5.13

  PR:		238782

Changes:
  head/sysutils/twmn/Makefile
Comment 13 commit-hook freebsd_committer freebsd_triage 2019-07-13 11:53:48 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 11:53:06 UTC 2019
New revision: 506539
URL: https://svnweb.freebsd.org/changeset/ports/506539

Log:
  graphics/radiance: prepare for Qt 5.13

  PR:		238782

Changes:
  head/graphics/radiance/files/
  head/graphics/radiance/files/patch-CMakeLists.txt
Comment 14 commit-hook freebsd_committer freebsd_triage 2019-07-13 12:00:56 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 11:59:53 UTC 2019
New revision: 506540
URL: https://svnweb.freebsd.org/changeset/ports/506540

Log:
  net-p2p/torrent-file-editor: prepare for Qt 5.13

  PR:		238782

Changes:
  head/net-p2p/torrent-file-editor/files/patch-CMakeLists.txt
Comment 15 commit-hook freebsd_committer freebsd_triage 2019-07-13 12:39:27 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 12:39:07 UTC 2019
New revision: 506541
URL: https://svnweb.freebsd.org/changeset/ports/506541

Log:
  net-im/nheko: prepare for Qt 5.13

  PR:		238782

Changes:
  head/net-im/nheko/files/
  head/net-im/nheko/files/patch-CMakeLists.txt
Comment 16 commit-hook freebsd_committer freebsd_triage 2019-07-13 12:50:37 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 12:50:05 UTC 2019
New revision: 506542
URL: https://svnweb.freebsd.org/changeset/ports/506542

Log:
  science/massxpert: prepare for Qt 5.13

  PR:		238782

Changes:
  head/science/massxpert/files/patch-CMakeLists.txt
Comment 17 commit-hook freebsd_committer freebsd_triage 2019-07-13 13:06:52 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 13:06:48 UTC 2019
New revision: 506544
URL: https://svnweb.freebsd.org/changeset/ports/506544

Log:
  graphics/qgis: prepare for Qt 5.13

  PR:		238782

Changes:
  head/graphics/qgis/files/patch-src_analysis_interpolation_qgsinterpolator.h
Comment 18 commit-hook freebsd_committer freebsd_triage 2019-07-13 14:18:51 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 14:18:45 UTC 2019
New revision: 506545
URL: https://svnweb.freebsd.org/changeset/ports/506545

Log:
  net/unetbootin: prepare for Qt 5.13

  PR:		238782

Changes:
  head/sysutils/unetbootin/Makefile
Comment 19 commit-hook freebsd_committer freebsd_triage 2019-07-13 18:14:06 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 18:13:37 UTC 2019
New revision: 506549
URL: https://svnweb.freebsd.org/changeset/ports/506549

Log:
  sysutils/qtpass: prepare for Qt 5.13

  PR:		238782

Changes:
  head/sysutils/qtpass/Makefile
Comment 20 commit-hook freebsd_committer freebsd_triage 2019-07-13 18:33:24 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 18:32:32 UTC 2019
New revision: 506550
URL: https://svnweb.freebsd.org/changeset/ports/506550

Log:
  games/multimc: prepare for Qt 5.13

  PR:		238782

Changes:
  head/games/multimc/files/patch-CMakeLists.txt
Comment 21 commit-hook freebsd_committer freebsd_triage 2019-07-13 19:24:06 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 19:23:41 UTC 2019
New revision: 506551
URL: https://svnweb.freebsd.org/changeset/ports/506551

Log:
  lang/basic256: prepare for Qt 5.13

  PR:		238782

Changes:
  head/lang/basic256/files/patch-BASIC256.pro
Comment 22 commit-hook freebsd_committer freebsd_triage 2019-07-13 20:12:45 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jul 13 20:12:34 UTC 2019
New revision: 506552
URL: https://svnweb.freebsd.org/changeset/ports/506552

Log:
  multimedia/shotcut: prepare for Qt 5.13

  PR:		238782

Changes:
  head/multimedia/shotcut/Makefile
Comment 23 Tobias C. Berner freebsd_committer freebsd_triage 2019-09-01 21:12:06 UTC
Created attachment 207077 [details]
v3

Thanks to adridg@'s fixes, this should be ready for a second go now.

https://people.freebsd.org/~tcberner/patches/qt5-5.13.0.v3.diff
Comment 26 Tobias C. Berner freebsd_committer freebsd_triage 2019-09-04 19:35:17 UTC
zygrib still seems to fail to fetch for me, so I cannot confirm the issue there.

We'll fix the other two.
Comment 27 commit-hook freebsd_committer freebsd_triage 2019-09-05 17:27:23 UTC
A commit references this bug:

Author: tcberner
Date: Thu Sep  5 17:26:21 UTC 2019
New revision: 511256
URL: https://svnweb.freebsd.org/changeset/ports/511256

Log:
  math/rkward-kde: add missing includes

  PR:		238782

Changes:
  head/math/rkward-kde/files/patch-rkward_rkward.cpp
  head/math/rkward-kde/files/patch-rkward_windows_rktoolwindowbar.cpp
  head/math/rkward-kde/files/patch-rkward_windows_rkworkplace.cpp
Comment 28 Tobias C. Berner freebsd_committer freebsd_triage 2019-09-13 11:39:56 UTC
Created attachment 207458 [details]
v4

The only expected failure now should be zygrib, which fails for me always
[00:00:10] [01] [00:00:02] Finished misc/zygrib | zygrib-8.0.1_3: Failed: checksum


https://people.freebsd.org/~tcberner/patches/qt5-5.13.0.v4.diff

mfg Tobias
Comment 30 Tobias Kortkamp freebsd_committer freebsd_triage 2019-09-16 12:04:20 UTC
Comment on attachment 207458 [details]
v4

+			sql-tds uiplugin uitools virtualkeyboard wayland webchannel webplugin \

In _USE_QT5_ONLY should this be 'webglplugin' instead of 'webplugin'?
Comment 31 Tobias C. Berner freebsd_committer freebsd_triage 2019-09-20 19:21:22 UTC
(In reply to Tobias Kortkamp from comment #30)
indeed it should, thanks for pointing that one out
Comment 32 commit-hook freebsd_committer freebsd_triage 2019-09-29 14:10:17 UTC
A commit references this bug:

Author: tcberner
Date: Sun Sep 29 14:10:14 UTC 2019
New revision: 513244
URL: https://svnweb.freebsd.org/changeset/ports/513244

Log:
  deskutils/syncthingtray: fix build with Qt5 5.13

  - syncthingtray uses the QT_VERSION to decide on QtWebengine features, instead
    of QTWEBENGINEWIDGETS_VERSION
  - when WebEngine and Core are out of sync as they tend to be for us, this leads to
    compilation errors.

  PR:		238782

Changes:
  head/deskutils/syncthingtray/files/
  head/deskutils/syncthingtray/files/patch-webengine-version-workaround
Comment 33 Tobias C. Berner freebsd_committer freebsd_triage 2019-09-29 14:46:52 UTC
Created attachment 207934 [details]
v5

Here's v5 of the patch, it includes a fix for emulators/virtualbox-ose -- synctraything has been fixed in the tree directly, and math/zygrib is on the way out, so I ignored it again :)

https://people.freebsd.org/~tcberner/patches/qt5-5.13.0.v5.diff
Comment 34 Piotr Kubaj freebsd_committer freebsd_triage 2019-09-30 16:57:51 UTC
(In reply to Tobias C. Berner from comment #33)
Are you going to also upgrade www/qt5-webengine to 5.13? It seems stuck at 5.12.2:
pkubaj@talos:$~/ports/www/qt5-webengine$ make -V PORTVERSION
5.12.2
pkubaj@talos:$~/ports/www/qt5-webengine$ cd ../../devel/qt5
pkubaj@talos:$~/ports/devel/qt5$ make -V PORTVERSION
5.13.0

I was going to try merging Void's patches for ppc64 (https://github.com/void-linux/void-packages/tree/master/srcpkgs/qt5/patches), but they seem to have jumped from 5.11 to 5.13.
Comment 35 Tobias C. Berner freebsd_committer freebsd_triage 2019-09-30 17:25:01 UTC
(In reply to Piotr Kubaj from comment #34)

We already have an upgrade pending by kai@ 
https://github.com/freebsd/freebsd-ports-kde/pull/48

The plan is to commit that one once the rest of Qt5-5.13 has landed -- as that one is bigger than the whole rest normally :D 


mfg Tobias
Comment 36 Antoine Brodin freebsd_committer freebsd_triage 2019-09-30 18:18:42 UTC
Exp-run looks fine
Comment 37 commit-hook freebsd_committer freebsd_triage 2019-10-01 04:13:54 UTC
A commit references this bug:

Author: tcberner
Date: Tue Oct  1 04:13:38 UTC 2019
New revision: 513447
URL: https://svnweb.freebsd.org/changeset/ports/513447

Log:
  Qt5 update to 5.13.0

  For new features, check: https://wiki.qt.io/New_Features_in_Qt_5.13

  Thanks to adridg who helped to fix a lot of packages.

  Exp-run by:	antoine
  PR:		238782

Changes:
  head/Mk/Uses/qt-dist.mk
  head/Mk/Uses/qt.mk
  head/accessibility/qt5-speech/Makefile
  head/comms/qt5-connectivity/pkg-plist
  head/comms/qt5-serialbus/pkg-plist
  head/deskutils/znotes/Makefile
  head/devel/grantlee5/files/patch-git_1b4f22-fix-qt5.13
  head/devel/qt5/distinfo
  head/devel/qt5/files/extrapatch-mkspecs_features_data_cmake_Qt5BasicConfig.cmake.in
  head/devel/qt5-assistant/Makefile
  head/devel/qt5-assistant/files/patch-src__src.pro
  head/devel/qt5-core/Makefile
  head/devel/qt5-core/pkg-plist
  head/devel/qt5-designer/files/patch-src__src.pro
  head/devel/qt5-help/files/patch-src__src.pro
  head/devel/qt5-help/pkg-plist
  head/devel/qt5-linguist/files/patch-src__src.pro
  head/devel/qt5-linguisttools/files/patch-src__src.pro
  head/devel/qt5-linguisttools/files/patch-src_linguist_linguist.pro
  head/devel/qt5-linguisttools/files/patch-src_linguist_lrelease_main.cpp
  head/devel/qt5-linguisttools/files/patch-src_linguist_shared_runqttool.cpp
  head/devel/qt5-linguisttools/pkg-plist
  head/devel/qt5-location/pkg-plist
  head/devel/qt5-qdbus/files/patch-src_src.pro
  head/devel/qt5-qdbusviewer/files/patch-src__src.pro
  head/devel/qt5-qdoc/files/patch-src_src.pro
  head/devel/qt5-qmake/Makefile
  head/devel/qt5-qmake/pkg-plist
  head/devel/qt5-scripttools/Makefile
  head/devel/qt5-testlib/pkg-plist
  head/devel/qt5-uitools/files/patch-src__src.pro
  head/devel/qtcreator/pkg-plist
  head/emulators/virtualbox-ose/files/patch-include_VBox_VBoxGL2D.h
  head/games/chessx/Makefile
  head/games/pentobi/files/
  head/games/pentobi/files/patch-src_pentobi_RatingDialog.cpp
  head/graphics/diffpdf/Makefile
  head/graphics/fractgen/files/
  head/graphics/fractgen/files/patch-src_colorschemeinterface.cc
  head/graphics/fractgen/files/patch-src_fractalalgorithminterface.cc
  head/graphics/gpxsee/Makefile
  head/graphics/qt5-3d/pkg-plist
  head/graphics/qt5-pixeltool/files/patch-src__src.pro
  head/graphics/qt5-wayland/pkg-plist
  head/math/rkward-kde/files/patch-rkward_windows_rkworkplace.cpp
  head/misc/qt5-doc/Makefile
  head/misc/qt5-examples/Makefile
  head/misc/qt5-examples/distinfo
  head/misc/qt5-examples/pkg-plist
  head/misc/qt5-l10n/pkg-plist
  head/multimedia/qt5-multimedia/Makefile
  head/multimedia/qt5-multimedia/files/patch-src_multimedia_configure.json
  head/multimedia/qt5-multimedia/pkg-plist
  head/net/qt5-network/Makefile
  head/net/qt5-network/files/patch-qdnslookup
  head/net/qt5-network/files/patch-src_network_ssl_qsslcontext__openssl.cpp
  head/net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl11__symbols__p.h
  head/net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols.cpp
  head/net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
  head/net/qt5-network/pkg-plist
  head/net/rclone-browser/files/patch-src_item__model.cpp
  head/net/rclone-browser/files/patch-src_job__widget.cpp
  head/net/rclone-browser/files/patch-src_main__window.cpp
  head/net/rclone-browser/files/patch-src_mount__widget.cpp
  head/net/rclone-browser/files/patch-src_remote__widget.cpp
  head/net/rclone-browser/files/patch-src_stream__widget.cpp
  head/net/rclone-browser/files/patch-src_transfer__dialog.cpp
  head/net-im/qTox/files/patch-git-0ac5386786733e1246ce49c483ebdf35c3291023
  head/net-im/qTox/files/patch-git-16452eff0c21abc2888150e4f9eefd12072fc656
  head/net-im/qTox/files/patch-git-24811d10420901199b2fe0a5f35a391272f24f36
  head/net-im/qTox/files/patch-git-34e1e25b7fb12dc662ed197e615c422ea56c867a
  head/net-im/qTox/files/patch-git-6e71ccfdad17b275961efff0a51a182de61ef963
  head/net-im/qTox/files/patch-git-8a0197b37f9c6098e28115d412895d337c326a91
  head/net-im/qTox/files/patch-git-b45ba34be250e938c6b07617e121d789ed52ca1d
  head/net-im/qTox/files/patch-git-ba9d724a17e76bfe7981a69330334c612f52a769
  head/net-im/qTox/files/patch-git-dbf56581bb90667dc44c6db230ee7076616149a0
  head/net-im/qTox/files/patch-git-dfe75fb101d8a8f24baa346312c2d847de6e45da
  head/net-im/qTox/files/patch-git-fb3f44721e6b49a3afbb57b407607c02674fe13a
  head/sysutils/signon-plugin-oauth2/Makefile
  head/www/Makefile
  head/www/qt5-webglplugin/
  head/www/qt5-webglplugin/Makefile
  head/www/qt5-webglplugin/pkg-plist
  head/x11-toolkits/Makefile
  head/x11-toolkits/qt5-canvas3d/pkg-plist
  head/x11-toolkits/qt5-charts/pkg-plist
  head/x11-toolkits/qt5-declarative/pkg-plist
  head/x11-toolkits/qt5-gamepad/Makefile
  head/x11-toolkits/qt5-gamepad/pkg-plist
  head/x11-toolkits/qt5-gui/Makefile
  head/x11-toolkits/qt5-gui/files/
  head/x11-toolkits/qt5-gui/pkg-plist
  head/x11-toolkits/qt5-quickcontrols/pkg-plist
  head/x11-toolkits/qt5-quickcontrols2/pkg-plist
  head/x11-toolkits/qt5-uiplugin/files/patch-src__src.pro
Comment 38 Tobias C. Berner freebsd_committer freebsd_triage 2019-10-01 04:36:18 UTC
Committed. 

Thanks for the exp-runs.